pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedAlignment issue at 43.10. Trigger Functions
4+ messages / 3 participants
[nested] [flat]
* Alignment issue at 43.10. Trigger Functions
@ 2022-11-17 18:14 PG Doc comments form <noreply@postgresql.org>
2022-11-18 06:21 ` Re: Alignment issue at 43.10. Trigger Functions Laurenz Albe <laurenz.albe@cybertec.at>
0 siblings, 1 reply; 4+ messages in thread
From: PG Doc comments form @ 2022-11-17 18:14 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: lemes.marcelo26@gmail.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/13/plpgsql-trigger.html
Description:
Type alignment issue for salary at "Example 43.4. A PL/pgSQL Trigger
Function for Auditing":
CREATE TABLE emp_audit(
operation char(1) NOT NULL,
stamp timestamp NOT NULL,
userid text NOT NULL,
empname text NOT NULL,
salary integer
);
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Alignment issue at 43.10. Trigger Functions
2022-11-17 18:14 Alignment issue at 43.10. Trigger Functions PG Doc comments form <noreply@postgresql.org>
@ 2022-11-18 06:21 ` Laurenz Albe <laurenz.albe@cybertec.at>
2022-12-02 10:42 ` Re: Alignment issue at 43.10. Trigger Functions Daniel Gustafsson <daniel@yesql.se>
0 siblings, 1 reply; 4+ messages in thread
From: Laurenz Albe @ 2022-11-18 06:21 UTC (permalink / raw)
To: lemes.marcelo26@gmail.com; pgsql-docs@lists.postgresql.org
On Thu, 2022-11-17 at 18:14 +0000, PG Doc comments form wrote:
> Page: https://www.postgresql.org/docs/13/plpgsql-trigger.html
>
> Type alignment issue for salary at "Example 43.4. A PL/pgSQL Trigger
> Function for Auditing":
>
> CREATE TABLE emp_audit(
> operation char(1) NOT NULL,
> stamp timestamp NOT NULL,
> userid text NOT NULL,
> empname text NOT NULL,
> salary integer
> );
Attached is a patch to fix that.
Yours,
Laurenz Albe
Attachments:
[text/x-patch] 0001-Fix-text-alignment-in-an-example.patch (782B, ../../b32f241d5016a8b1af933ec52be848bcf0c99ce3.camel@cybertec.at/2-0001-Fix-text-alignment-in-an-example.patch)
download | inline diff:
From 4cfc7ec4b655a8317a918e3a4a0791433af58a63 Mon Sep 17 00:00:00 2001
From: Laurenz Albe <laurenz.albe@cybertec.at>
Date: Fri, 18 Nov 2022 07:19:30 +0100
Subject: [PATCH] Fix text alignment in an example
---
doc/src/sgml/plpgsql.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/src/sgml/plpgsql.sgml b/doc/src/sgml/plpgsql.sgml
index d85f89bf30..e80ab2913f 100644
--- a/doc/src/sgml/plpgsql.sgml
+++ b/doc/src/sgml/plpgsql.sgml
@@ -4301,7 +4301,7 @@ CREATE TABLE emp_audit(
stamp timestamp NOT NULL,
userid text NOT NULL,
empname text NOT NULL,
- salary integer
+ salary integer
);
CREATE OR REPLACE FUNCTION process_emp_audit() RETURNS TRIGGER AS $emp_audit$
--
2.38.1
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Alignment issue at 43.10. Trigger Functions
2022-11-17 18:14 Alignment issue at 43.10. Trigger Functions PG Doc comments form <noreply@postgresql.org>
2022-11-18 06:21 ` Re: Alignment issue at 43.10. Trigger Functions Laurenz Albe <laurenz.albe@cybertec.at>
@ 2022-12-02 10:42 ` Daniel Gustafsson <daniel@yesql.se>
2022-12-02 12:33 ` Re: Alignment issue at 43.10. Trigger Functions Laurenz Albe <laurenz.albe@cybertec.at>
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Gustafsson @ 2022-12-02 10:42 UTC (permalink / raw)
To: Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: lemes.marcelo26@gmail.com; pgsql-docs@lists.postgresql.org
> On 18 Nov 2022, at 07:21, Laurenz Albe <laurenz.albe@cybertec.at> wrote:
>
> On Thu, 2022-11-17 at 18:14 +0000, PG Doc comments form wrote:
>> Page: https://www.postgresql.org/docs/13/plpgsql-trigger.html
>>
>> Type alignment issue for salary at "Example 43.4. A PL/pgSQL Trigger
>> Function for Auditing":
>>
>> CREATE TABLE emp_audit(
>> operation char(1) NOT NULL,
>> stamp timestamp NOT NULL,
>> userid text NOT NULL,
>> empname text NOT NULL,
>> salary integer
>> );
>
> Attached is a patch to fix that.
There was a second occurrence of the above, as well as one table which had no
vertical alignment at all. I fixed these and applied your patch to master.
--
Daniel Gustafsson https://vmware.com/
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Alignment issue at 43.10. Trigger Functions
2022-11-17 18:14 Alignment issue at 43.10. Trigger Functions PG Doc comments form <noreply@postgresql.org>
2022-11-18 06:21 ` Re: Alignment issue at 43.10. Trigger Functions Laurenz Albe <laurenz.albe@cybertec.at>
2022-12-02 10:42 ` Re: Alignment issue at 43.10. Trigger Functions Daniel Gustafsson <daniel@yesql.se>
@ 2022-12-02 12:33 ` Laurenz Albe <laurenz.albe@cybertec.at>
0 siblings, 0 replies; 4+ messages in thread
From: Laurenz Albe @ 2022-12-02 12:33 UTC (permalink / raw)
To: Daniel Gustafsson <daniel@yesql.se>; +Cc: lemes.marcelo26@gmail.com; pgsql-docs@lists.postgresql.org
On Fri, 2022-12-02 at 11:42 +0100, Daniel Gustafsson wrote:
>
> I fixed these and applied your patch to master.
Thanks for taking care of this small matter.
Yours,
Laurenz Albe
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2022-12-02 12:33 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-11-17 18:14 Alignment issue at 43.10. Trigger Functions PG Doc comments form <noreply@postgresql.org>
2022-11-18 06:21 ` Laurenz Albe <laurenz.albe@cybertec.at>
2022-12-02 10:42 ` Daniel Gustafsson <daniel@yesql.se>
2022-12-02 12:33 ` Laurenz Albe <laurenz.albe@cybertec.at>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox