From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
cc: "David G. Johnston" <david.g.johnston@gmail.com>,
        Guyren Howe <guyren@gmail.com>,
        Pg Docs <pgsql-docs@lists.postgresql.org>
Subject: Re: Please provide examples of rows from
In-reply-to: <20200924185511.GC22807@momjian.us>
References: <158638264419.662.2482095087061084020@wrigleys.postgresql.org>
 <20200904014618.GB13932@momjian.us>
 <CAKFQuwbBDr22KJRyJQRECO_XU6cyouwz3ocn0Tv4JgG4Gm5hMQ@mail.gmail.com>
 <20200920003910.GA22746@momjian.us> <798909.1600562993@sss.pgh.pa.us>
 <20200920013846.GC22746@momjian.us> <835988.1600613834@sss.pgh.pa.us>
 <878265.1600625640@sss.pgh.pa.us> <20200924185511.GC22807@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Thu, 24 Sep 2020 14:55:11 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1668962.1600974324.1@sss.pgh.pa.us>
Date: Thu, 24 Sep 2020 15:05:24 -0400
Message-ID: <1668963.1600974324@sss.pgh.pa.us>
Precedence: bulk

Bruce Momjian <bruce@momjian.us> writes:
> Yes, this is very helpful.  I was afraid the JSON would overwhelm the
> example, but this looks good.  I wrote the attached doc patch which I
> think improves this.  I plan to apply it to all supported versions.

Couple thoughts:

* Taking the initial ... out of the syntax synopsis is not an improvement.
It makes it look like you can only apply AS to the first function of a
ROWS FROM.

* I think the ORDER BY adds nothing to the example except complication
and confusion.

* Maybe the other sentence of explanation would read better as

	json_to_recordset() is instructed to return two columns,
	the first integer and the second text.  The result of
	generate_series() is used directly.

			regards, tom lane