pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
Missing ;
5+ messages / 4 participants
[nested] [flat]

* Missing ;
@ 2023-11-10 21:00 PG Doc comments form <noreply@postgresql.org>
  2023-11-13 11:22 ` Re: Missing ; Daniel Gustafsson <daniel@yesql.se>
  0 siblings, 1 reply; 5+ messages in thread

From: PG Doc comments form @ 2023-11-10 21:00 UTC (permalink / raw)
  To: pgsql-docs@lists.postgresql.org; +Cc: tim.needham2@gmail.com

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/16/sql-select.html
Description:

Hi,

To be consistent, the "with" example should end in a ";".

WITH t AS (
    SELECT random() as x FROM generate_series(1, 3)
  )
SELECT * FROM t
UNION ALL
SELECT * FROM t;

Possibly the most pathetic contribution ever? 
Apologies.

Tim


^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Missing ;
  2023-11-10 21:00 Missing ; PG Doc comments form <noreply@postgresql.org>
@ 2023-11-13 11:22 ` Daniel Gustafsson <daniel@yesql.se>
  0 siblings, 0 replies; 5+ messages in thread

From: Daniel Gustafsson @ 2023-11-13 11:22 UTC (permalink / raw)
  To: tim.needham2@gmail.com; pgsql-docs@lists.postgresql.org

> On 10 Nov 2023, at 22:00, PG Doc comments form <noreply@postgresql.org> wrote:
> 
> The following documentation comment has been logged on the website:
> 
> Page: https://www.postgresql.org/docs/16/sql-select.html
> Description:
> 
> Hi,
> 
> To be consistent, the "with" example should end in a ";".
> 
> WITH t AS (
>    SELECT random() as x FROM generate_series(1, 3)
>  )
> SELECT * FROM t
> UNION ALL
> SELECT * FROM t;

Thats absolutely right, it should end with a semicolon.

> Possibly the most pathetic contribution ever? 
> Apologies.

No need for an apology.  *All* contributions are valuable, big and small.  I'll
go ahead and fix this, thanks for the report!

--
Daniel Gustafsson






^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Missing | ?
@ 2024-02-19 09:37 PG Doc comments form <noreply@postgresql.org>
  2024-02-19 17:48 ` Re: Missing | ? Laurenz Albe <laurenz.albe@cybertec.at>
  0 siblings, 1 reply; 5+ messages in thread

From: PG Doc comments form @ 2024-02-19 09:37 UTC (permalink / raw)
  To: pgsql-docs@lists.postgresql.org; +Cc: tim.needham2@gmail.com

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/16/sql-security-label.html
Description:

Hi,

FOREIGN TABLE object_name

...probably should have a following "|", I think?

Cheers

Tim


^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Missing | ?
  2024-02-19 09:37 Missing | ? PG Doc comments form <noreply@postgresql.org>
@ 2024-02-19 17:48 ` Laurenz Albe <laurenz.albe@cybertec.at>
  2024-02-19 19:10   ` Re: Missing | ? Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 5+ messages in thread

From: Laurenz Albe @ 2024-02-19 17:48 UTC (permalink / raw)
  To: tim.needham2@gmail.com; pgsql-docs@lists.postgresql.org

On Mon, 2024-02-19 at 09:37 +0000, PG Doc comments form wrote:
> Page: https://www.postgresql.org/docs/16/sql-security-label.html
> 
> FOREIGN TABLE object_name
> 
> ...probably should have a following "|", I think?

Absolutely!

Yours,
Laurenz Albe





^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Missing | ?
  2024-02-19 09:37 Missing | ? PG Doc comments form <noreply@postgresql.org>
  2024-02-19 17:48 ` Re: Missing | ? Laurenz Albe <laurenz.albe@cybertec.at>
@ 2024-02-19 19:10   ` Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 5+ messages in thread

From: Tom Lane @ 2024-02-19 19:10 UTC (permalink / raw)
  To: Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: tim.needham2@gmail.com; pgsql-docs@lists.postgresql.org

Laurenz Albe <laurenz.albe@cybertec.at> writes:
> On Mon, 2024-02-19 at 09:37 +0000, PG Doc comments form wrote:
>> Page: https://www.postgresql.org/docs/16/sql-security-label.html
>> FOREIGN TABLE object_name
>> 
>> ...probably should have a following "|", I think?

> Absolutely!

Indeed.  Will fix, thanks for report!

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2024-02-19 19:10 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-11-10 21:00 Missing ; PG Doc comments form <noreply@postgresql.org>
2023-11-13 11:22 ` Daniel Gustafsson <daniel@yesql.se>
2024-02-19 09:37 Missing | ? PG Doc comments form <noreply@postgresql.org>
2024-02-19 17:48 ` Re: Missing | ? Laurenz Albe <laurenz.albe@cybertec.at>
2024-02-19 19:10   ` Re: Missing | ? Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox