pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedDocumentation does not describes format for access privileges: =Tc/user
6+ messages / 4 participants
[nested] [flat]
* Documentation does not describes format for access privileges: =Tc/user
@ 2023-12-22 16:06 PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 6+ messages in thread
From: PG Doc comments form @ 2023-12-22 16:06 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: konkove@gmail.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/16/ddl-priv.html
Description:
Hello.
The page https://www.postgresql.org/docs/current/ddl-priv.html does not
describe what =Tc/user means. Also I did not find a link to appropriate page
which describes this.
Specifically I do not understand how 'user=Tc/user' differs from
'=Tc/user'.
It would be nice if documentation will be extended.
Thank you.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Documentation does not describes format for access privileges: =Tc/user
@ 2023-12-24 15:12 David G. Johnston <david.g.johnston@gmail.com>
parent: PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 6+ messages in thread
From: David G. Johnston @ 2023-12-24 15:12 UTC (permalink / raw)
To: konkove@gmail.com <konkove@gmail.com>; pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
On Friday, December 22, 2023, PG Doc comments form <noreply@postgresql.org>
wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/16/ddl-priv.html
> Description:
>
> Hello.
> The page https://www.postgresql.org/docs/current/ddl-priv.html does not
> describe what =Tc/user means. Also I did not find a link to appropriate
> page
> which describes this.
> Specifically I do not understand how 'user=Tc/user' differs from
> '=Tc/user'.
>
> It would be nice if documentation will be extended.
>
>
The paragraph immediately following table 5.2 describes all of this.
David J.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Documentation does not describes format for access privileges: =Tc/user
@ 2023-12-25 17:48 Eugen Konkov <konkove@gmail.com>
parent: David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Eugen Konkov @ 2023-12-25 17:48 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
No, it does not. If you refer to `An empty grantee field in an aclitem
stands for PUBLIC.` then "grantee field" was never described. What is
this?
It would be very clear if it was described in this way:
The access privileges has the following format: "grantee=privileges/who grants".
On Sun, Dec 24, 2023 at 10:13 AM David G. Johnston
<david.g.johnston@gmail.com> wrote:
>
> On Friday, December 22, 2023, PG Doc comments form <noreply@postgresql.org> wrote:
>>
>> The following documentation comment has been logged on the website:
>>
>> Page: https://www.postgresql.org/docs/16/ddl-priv.html
>> Description:
>>
>> Hello.
>> The page https://www.postgresql.org/docs/current/ddl-priv.html does not
>> describe what =Tc/user means. Also I did not find a link to appropriate page
>> which describes this.
>> Specifically I do not understand how 'user=Tc/user' differs from
>> '=Tc/user'.
>>
>> It would be nice if documentation will be extended.
>>
>
> The paragraph immediately following table 5.2 describes all of this.
>
> David J.
>
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Documentation does not describes format for access privileges: =Tc/user
@ 2023-12-25 18:02 David G. Johnston <david.g.johnston@gmail.com>
parent: Eugen Konkov <konkove@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: David G. Johnston @ 2023-12-25 18:02 UTC (permalink / raw)
To: Eugen Konkov <konkove@gmail.com>; +Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
On Monday, December 25, 2023, Eugen Konkov <konkove@gmail.com> wrote:
> No, it does not. If you refer to `An empty grantee field in an aclitem
> stands for PUBLIC.` then "grantee field" was never described. What is
> this?
>
> It would be very clear if it was described in this way:
> The access privileges has the following format: "grantee=privileges/who
> grants".
>
>
Yes, it requires a bit of mental gymnastics to read. The description says
Calvin is the role being granted the privileges which makes that the
grantee and Calvin is listed before the equal sign in the reference.
“Who grants” is the “grantor”.
I’ll accept that this can be improved but aside from a dictionary
definition of grantee, which we don’t usually do, everything is shown.
David J.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Documentation does not describes format for access privileges: =Tc/user
@ 2023-12-25 18:16 David G. Johnston <david.g.johnston@gmail.com>
parent: David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: David G. Johnston @ 2023-12-25 18:16 UTC (permalink / raw)
To: Eugen Konkov <konkove@gmail.com>; +Cc: pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
On Monday, December 25, 2023, David G. Johnston <david.g.johnston@gmail.com>
wrote:
> On Monday, December 25, 2023, Eugen Konkov <konkove@gmail.com> wrote:
>
>> No, it does not. If you refer to `An empty grantee field in an aclitem
>> stands for PUBLIC.` then "grantee field" was never described. What is
>> this?
>>
>> It would be very clear if it was described in this way:
>> The access privileges has the following format: "grantee=privileges/who
>> grants".
>>
>>
> Yes, it requires a bit of mental gymnastics to read. The description says
> Calvin is the role being granted the privileges which makes that the
> grantee and Calvin is listed before the equal sign in the reference.
>
> “Who grants” is the “grantor”.
>
> I’ll accept that this can be improved but aside from a dictionary
> definition of grantee, which we don’t usually do, everything is shown.
>
We probably should write the syntax like we do everywhere else:
[grantee]={privilege[*]}[…]/grantor
Then define the placeholders in the subsequent paragraph.
David J.
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Documentation does not describes format for access privileges: =Tc/user
@ 2023-12-25 18:31 Tom Lane <tgl@sss.pgh.pa.us>
parent: David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 0 replies; 6+ messages in thread
From: Tom Lane @ 2023-12-25 18:31 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: Eugen Konkov <konkove@gmail.com>; pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> We probably should write the syntax like we do everywhere else:
> [grantee]={privilege[*]}[…]/grantor
> Then define the placeholders in the subsequent paragraph.
Seems reasonable. About like this?
regards, tom lane
Attachments:
[text/x-diff] doc-aclitem-format-explicitly.patch (1000B, ../../1887860.1703529071@sss.pgh.pa.us/2-doc-aclitem-format-explicitly.patch)
download | inline diff:
diff --git a/doc/src/sgml/ddl.sgml b/doc/src/sgml/ddl.sgml
index d2951cd754..664361a724 100644
--- a/doc/src/sgml/ddl.sgml
+++ b/doc/src/sgml/ddl.sgml
@@ -2318,8 +2318,12 @@ REVOKE ALL ON accounts FROM PUBLIC;
<primary><type>aclitem</type></primary>
</indexterm>
The privileges that have been granted for a particular object are
- displayed as a list of <type>aclitem</type> entries, where each
- <type>aclitem</type> describes the permissions of one grantee that
+ displayed as a list of <type>aclitem</type> entries, each having the
+ format:
+<synopsis>
+<replaceable>grantee</replaceable><literal>=</literal><replaceable>privilege-abbreviations</replaceable><literal>/</literal><replaceable>grantor</replaceable>
+</synopsis>
+ Each <type>aclitem</type> describes the permissions of one grantee that
have been granted by a particular grantor. For example,
<literal>calvin=r*w/hobbes</literal> specifies that the role
<literal>calvin</literal> has the privilege
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2023-12-25 18:31 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-12-22 16:06 Documentation does not describes format for access privileges: =Tc/user PG Doc comments form <noreply@postgresql.org>
2023-12-24 15:12 ` David G. Johnston <david.g.johnston@gmail.com>
2023-12-25 17:48 ` Eugen Konkov <konkove@gmail.com>
2023-12-25 18:02 ` David G. Johnston <david.g.johnston@gmail.com>
2023-12-25 18:16 ` David G. Johnston <david.g.johnston@gmail.com>
2023-12-25 18:31 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox