agora inbox for pgsql-docs@postgresql.org
help / color / mirror / Atom feedRe: Change JOIN tutorial to focus more on explicit joins
5+ messages / 4 participants
[nested] [flat]
* Re: Change JOIN tutorial to focus more on explicit joins
@ 2020-07-17 23:48 Thomas Munro <thomas.munro@gmail.com>
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Munro @ 2020-07-17 23:48 UTC (permalink / raw)
To: Jürgen Purtz <juergen@purtz.de>; +Cc: shammat@gmx.net; pgsql-docs@lists.postgresql.org
On Wed, May 27, 2020 at 8:29 PM Jürgen Purtz <juergen@purtz.de> wrote:
> > The "new" syntax is 28 years old, from SQL 92. I don't see too many
> > SQL 86 joins. Would you like to write a documentation patch?
> >
> >
> The attached patch
>
> - prefers the explicit join-syntax over the implicit one and explains
> the keywords of the explicit syntax
>
> - uses a more accurate definition of 'join'
>
> - separates <programlisting> and <screen> tags
>
> - shifts <indexterm> definitions outside of <para> to get a better
> rendering in PDF
>
> - adds a note concerning IDs and foreign keys
Hi Jürgen,
Please add to the commitfest app, so we don't lose track of it.
^ permalink raw reply [nested|flat] 5+ messages in thread
* Connection Info
@ 2024-05-05 20:25 PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 5+ messages in thread
From: PG Doc comments form @ 2024-05-05 20:25 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: k.man.113@gmail.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/14/server-start.html
Description:
Hello!
On this page:
https://www.postgresql.org/docs/14/server-start.html#CLIENT-CONNECTION-PROBLEMS
It notes: ".... A common mistake is to forget to configure the server to
allow TCP/IP connections."
I would expect a hyperlink to a section explaining exactly HOW to "configure
the server to allow TCP/IP connections" - from that note text.
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Connection Info
@ 2024-05-06 14:15 Laurenz Albe <laurenz.albe@cybertec.at>
parent: PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 5+ messages in thread
From: Laurenz Albe @ 2024-05-06 14:15 UTC (permalink / raw)
To: k.man.113@gmail.com; pgsql-docs@lists.postgresql.org
On Sun, 2024-05-05 at 20:25 +0000, PG Doc comments form wrote:
> On this page:
> https://www.postgresql.org/docs/14/server-start.html#CLIENT-CONNECTION-PROBLEMS
>
> It notes: ".... A common mistake is to forget to configure the server to
> allow TCP/IP connections."
>
> I would expect a hyperlink to a section explaining exactly HOW to "configure
> the server to allow TCP/IP connections" - from that note text.
I agree.
Perhaps it should say:
A common mistake is to forget to configure "listen_addresses" so that the
server accepts remote TCP connections.
Then "listen_addresses" could hyperlink to the parameter's documentation.
Yours,
Laurenz Albe
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Connection Info
@ 2024-10-17 01:36 Bruce Momjian <bruce@momjian.us>
parent: Laurenz Albe <laurenz.albe@cybertec.at>
0 siblings, 1 reply; 5+ messages in thread
From: Bruce Momjian @ 2024-10-17 01:36 UTC (permalink / raw)
To: Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: k.man.113@gmail.com; pgsql-docs@lists.postgresql.org
On Mon, May 6, 2024 at 04:15:24PM +0200, Laurenz Albe wrote:
> On Sun, 2024-05-05 at 20:25 +0000, PG Doc comments form wrote:
> > On this page:
> > https://www.postgresql.org/docs/14/server-start.html#CLIENT-CONNECTION-PROBLEMS
> >
> > It notes: ".... A common mistake is to forget to configure the server to
> > allow TCP/IP connections."
> >
> > I would expect a hyperlink to a section explaining exactly HOW to "configure
> > the server to allow TCP/IP connections" - from that note text.
>
> I agree.
>
> Perhaps it should say:
>
> A common mistake is to forget to configure "listen_addresses" so that the
> server accepts remote TCP connections.
>
> Then "listen_addresses" could hyperlink to the parameter's documentation.
Agreed, patch attached.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"
Attachments:
[text/x-diff] listen.diff (659B, ../../ZxBqAJ37NmchyvVI@momjian.us/2-listen.diff)
download | inline diff:
diff --git a/doc/src/sgml/runtime.sgml b/doc/src/sgml/runtime.sgml
index 2c4d5ef640d..933cac813c2 100644
--- a/doc/src/sgml/runtime.sgml
+++ b/doc/src/sgml/runtime.sgml
@@ -637,7 +637,8 @@ psql: error: connection to server at "server.joe.com" (123.123.123.123), port 54
This is the generic <quote>I couldn't find a server to talk
to</quote> failure. It looks like the above when TCP/IP
communication is attempted. A common mistake is to forget to
- configure the server to allow TCP/IP connections.
+ configure <xref linkend="guc-listen-addresses"/> so that the server
+ accepts remote TCP connections.
</para>
<para>
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Connection Info
@ 2024-11-01 17:14 Bruce Momjian <bruce@momjian.us>
parent: Bruce Momjian <bruce@momjian.us>
0 siblings, 0 replies; 5+ messages in thread
From: Bruce Momjian @ 2024-11-01 17:14 UTC (permalink / raw)
To: Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: k.man.113@gmail.com; pgsql-docs@lists.postgresql.org
On Wed, Oct 16, 2024 at 09:36:00PM -0400, Bruce Momjian wrote:
> On Mon, May 6, 2024 at 04:15:24PM +0200, Laurenz Albe wrote:
> > On Sun, 2024-05-05 at 20:25 +0000, PG Doc comments form wrote:
> > > On this page:
> > > https://www.postgresql.org/docs/14/server-start.html#CLIENT-CONNECTION-PROBLEMS
> > >
> > > It notes: ".... A common mistake is to forget to configure the server to
> > > allow TCP/IP connections."
> > >
> > > I would expect a hyperlink to a section explaining exactly HOW to "configure
> > > the server to allow TCP/IP connections" - from that note text.
> >
> > I agree.
> >
> > Perhaps it should say:
> >
> > A common mistake is to forget to configure "listen_addresses" so that the
> > server accepts remote TCP connections.
> >
> > Then "listen_addresses" could hyperlink to the parameter's documentation.
>
> Agreed, patch attached.
Patch applied.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2024-11-01 17:14 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 23:48 Re: Change JOIN tutorial to focus more on explicit joins Thomas Munro <thomas.munro@gmail.com>
2024-05-05 20:25 Connection Info PG Doc comments form <noreply@postgresql.org>
2024-05-06 14:15 ` Re: Connection Info Laurenz Albe <laurenz.albe@cybertec.at>
2024-10-17 01:36 ` Re: Connection Info Bruce Momjian <bruce@momjian.us>
2024-11-01 17:14 ` Re: Connection Info Bruce Momjian <bruce@momjian.us>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox