pg.ddx.io pgsql-docs@postgresql.org mailing list archive
help / color / mirror / Atom feedExplanations not clear
4+ messages / 3 participants
[nested] [flat]
* Explanations not clear
@ 2024-05-06 17:59 PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 4+ messages in thread
From: PG Doc comments form @ 2024-05-06 17:59 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: florian.murat.koch@gmail.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/16/collation.html
Description:
I created a collation specifying the ks-level3 setting and with
deterministic set to false. But when I compare "a_b" to "a-b" with this
collation I get false. According to the table 24.1 it should yield true.
Only after adding ka-shifted this comparison becomes true. The interactions
of the different options are not very clear. What is the difference for each
level when using ks without ka and with ka? The explanations for the options
kc and kb are also not very helpful. Also the role of deterministic = false
is not very good explained. It seems that the settings ks, ka and kc loose
any meaning with this setting.
Thank you very much
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Explanations not clear
@ 2024-05-08 06:52 Peter Eisentraut <peter@eisentraut.org>
parent: PG Doc comments form <noreply@postgresql.org>
0 siblings, 1 reply; 4+ messages in thread
From: Peter Eisentraut @ 2024-05-08 06:52 UTC (permalink / raw)
To: florian.murat.koch@gmail.com; pgsql-docs@lists.postgresql.org; +Cc: Jeff Davis <pgsql@j-davis.com>
On 06.05.24 19:59, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/16/collation.html
> Description:
>
> I created a collation specifying the ks-level3 setting and with
> deterministic set to false. But when I compare "a_b" to "a-b" with this
> collation I get false. According to the table 24.1 it should yield true.
> Only after adding ka-shifted this comparison becomes true. The interactions
> of the different options are not very clear.
I think table 24.1 is somewhat incorrect in the sense that punctuation
is only level 4 if you use ka-shifted, otherwise it's level 1. This
should perhaps be clarified.
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Explanations not clear
@ 2024-05-13 19:10 Jeff Davis <pgsql@j-davis.com>
parent: Peter Eisentraut <peter@eisentraut.org>
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Davis @ 2024-05-13 19:10 UTC (permalink / raw)
To: Peter Eisentraut <peter@eisentraut.org>; florian.murat.koch@gmail.com; pgsql-docs@lists.postgresql.org
On Wed, 2024-05-08 at 08:52 +0200, Peter Eisentraut wrote:
> > I created a collation specifying the ks-level3 setting and with
> > deterministic set to false. But when I compare "a_b" to "a-b" with
> > this
> > collation I get false. According to the table 24.1 it should yield
> > true.
> > Only after adding ka-shifted this comparison becomes true. The
> > interactions
> > of the different options are not very clear.
>
> I think table 24.1 is somewhat incorrect in the sense that
> punctuation
> is only level 4 if you use ka-shifted, otherwise it's level 1. This
> should perhaps be clarified.
One option is to just include 3 levels (plus "identic") in the table,
and then later document that ka-shifted creates a fourth level and
moves punctuation character differences into that level. That explains
the mechanism but detracts from the examples.
Another option is to say that all the examples in the table are using
ka-shifted for illustration purposes. I like this option, but it's a
bit awkward because it refers to something that hasn't been explained
yet. It's also only relevant for the 'x-y' = 'x_y' example, which might
be slightly confusing.
Thoughts?
Regards,
Jeff Davis
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Explanations not clear
@ 2024-05-14 07:38 Peter Eisentraut <peter@eisentraut.org>
parent: Jeff Davis <pgsql@j-davis.com>
0 siblings, 0 replies; 4+ messages in thread
From: Peter Eisentraut @ 2024-05-14 07:38 UTC (permalink / raw)
To: Jeff Davis <pgsql@j-davis.com>; florian.murat.koch@gmail.com; pgsql-docs@lists.postgresql.org
On 13.05.24 21:10, Jeff Davis wrote:
> On Wed, 2024-05-08 at 08:52 +0200, Peter Eisentraut wrote:
>>> I created a collation specifying the ks-level3 setting and with
>>> deterministic set to false. But when I compare "a_b" to "a-b" with
>>> this
>>> collation I get false. According to the table 24.1 it should yield
>>> true.
>>> Only after adding ka-shifted this comparison becomes true. The
>>> interactions
>>> of the different options are not very clear.
>>
>> I think table 24.1 is somewhat incorrect in the sense that
>> punctuation
>> is only level 4 if you use ka-shifted, otherwise it's level 1. This
>> should perhaps be clarified.
>
> One option is to just include 3 levels (plus "identic") in the table,
> and then later document that ka-shifted creates a fourth level and
> moves punctuation character differences into that level. That explains
> the mechanism but detracts from the examples.
>
> Another option is to say that all the examples in the table are using
> ka-shifted for illustration purposes. I like this option, but it's a
> bit awkward because it refers to something that hasn't been explained
> yet. It's also only relevant for the 'x-y' = 'x_y' example, which might
> be slightly confusing.
>
> Thoughts?
Maybe with a forward reference in a footnote, like this:
diff --git a/doc/src/sgml/charset.sgml b/doc/src/sgml/charset.sgml
index daf671e6205..10c12adf634 100644
--- a/doc/src/sgml/charset.sgml
+++ b/doc/src/sgml/charset.sgml
@@ -1320,7 +1320,7 @@ <title>ICU Collation Levels</title>
</row>
<row>
<entry>level4</entry>
- <entry>Punctuation</entry>
+ <entry>Punctuation<footnote><para>only with
<literal>ka-shifted</literal>; see <xref
linkend="icu-collation-settings-table"/></para></footnote></entry>
<entry><literal>true</literal></entry>
<entry><literal>true</literal></entry>
<entry><literal>false</literal></entry>
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-05-14 07:38 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-05-06 17:59 Explanations not clear PG Doc comments form <noreply@postgresql.org>
2024-05-08 06:52 ` Peter Eisentraut <peter@eisentraut.org>
2024-05-13 19:10 ` Jeff Davis <pgsql@j-davis.com>
2024-05-14 07:38 ` Peter Eisentraut <peter@eisentraut.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox