Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1lmGyJ-0008BD-CF
	for pgsql-docs@arkaria.postgresql.org; Thu, 27 May 2021 14:26:51 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-docs-owner+archive@lists.postgresql.org>)
	id 1lmGyI-0004Vb-Ak
	for pgsql-docs@arkaria.postgresql.org; Thu, 27 May 2021 14:26:50 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1lmGyI-0004VT-4v
	for pgsql-docs@lists.postgresql.org; Thu, 27 May 2021 14:26:50 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1lmGyG-0004do-8a
	for pgsql-docs@lists.postgresql.org; Thu, 27 May 2021 14:26:49 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 14REQj9H1718746;
	Thu, 27 May 2021 10:26:45 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
cc: Bruce Momjian <bruce@momjian.us>,
        "pgsql-docs@lists.postgresql.org" <pgsql-docs@lists.postgresql.org>,
        Michael Paquier <michael@paquier.xyz>
Subject: Re: pg_type_d.h location incorrect
In-reply-to: 
 <OS0PR01MB61139DA2FBBBB092F5371265FB239@OS0PR01MB6113.jpnprd01.prod.outlook.com>
References: <162149020918.26174.7150424047314144297@wrigleys.postgresql.org>
 <OS0PR01MB6113637F7DBED4565902A460FB249@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <1424852.1621999180@sss.pgh.pa.us>
 <OS0PR01MB61131DD84072DC0DC5E3E003FB249@OS0PR01MB6113.jpnprd01.prod.outlook.com>
 <YK4A4g07AvGa9FVF@paquier.xyz> <1681252.1622080694@sss.pgh.pa.us>
 <OS0PR01MB61139DA2FBBBB092F5371265FB239@OS0PR01MB6113.jpnprd01.prod.outlook.com>
Comments: In-reply-to "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
	message dated "Thu, 27 May 2021 06:13:36 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1718744.1622125605.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 27 May 2021 10:26:45 -0400
Message-ID: <1718745.1622125605@sss.pgh.pa.us>
List-Id: <pgsql-docs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-docs@lists.postgresql.org>
List-Owner: <mailto:pgsql-docs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-docs>
Archived-At: 
 <https://www.postgresql.org/message-id/1718745.1622125605%40sss.pgh.pa.us>
Precedence: bulk

"tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com> writes:
> On Thursday, May 27, 2021 10:58 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote
>> So I ended up with the attached --- what do you think?

> The doc-fix LGTM. =

> But I couldn't apply the patch at HEAD(2941138e60). Maybe you did the fi=
x at a branch other than HEAD?

No ... "patch -p1 <~/improve-pgservice-docs.patch" works fine for me.

>> Also, looking at this, I note that "~/.pg_service.conf" is still a
>> platform-ism.  We could make that slightly better by writing
>> "$HOME/.pg_service.conf", but is that good enough?

> Agreed. Besides, A lot of places in current Doc have been useing ~/.pg_*=
** already.
> IMHO, it's good to keep the consistency.

Oh, good point ... grepping finds lots of occurrences of '~/' and
only one of '$HOME/'.  Seems like we ought to change that one:

$ grep -r 'HOME/' .
./config.sgml:        This writes out files to <filename>$HOME/.debug/jit/=
</filename>; the

			regards, tom lane