pg.ddx.io  pgsql-docs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
Undocumented := alternative in using option of raise statement
3+ messages / 3 participants
[nested] [flat]

* Undocumented := alternative in using option of raise statement
@ 2024-07-22 08:00  PG Doc comments form <noreply@postgresql.org>
  0 siblings, 1 reply; 3+ messages in thread

From: PG Doc comments form @ 2024-07-22 08:00 UTC (permalink / raw)
  To: pgsql-docs@lists.postgresql.org; +Cc: philipp.salvisberg@gmail.com

The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/16/plpgsql-errors-and-messages.html
Description:

The using option is documented as follows for all variants of the raise
statement:

USING option = expression [, ... ]

However, since "do $$ begin raise notice using message := 'foo'; end $$;"
works and the alternative to "=" is documented in
https://www.postgresql.org/docs/current/plpgsql-statements.html#PLPGSQL-STATEMENTS-ASSIGNMENT
I suggest to change the grammar to

USING option { := | = } expression [, ... ]

for the raise statement.


^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: Undocumented := alternative in using option of raise statement
@ 2024-07-22 13:18  jian he <jian.universality@gmail.com>
  parent: PG Doc comments form <noreply@postgresql.org>
  0 siblings, 1 reply; 3+ messages in thread

From: jian he @ 2024-07-22 13:18 UTC (permalink / raw)
  To: philipp.salvisberg@gmail.com; pgsql-docs@lists.postgresql.org

On Mon, Jul 22, 2024 at 8:38 PM PG Doc comments form
<noreply@postgresql.org> wrote:
>
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/16/plpgsql-errors-and-messages.html
> Description:
>
> The using option is documented as follows for all variants of the raise
> statement:
>
> USING option = expression [, ... ]
>
> However, since "do $$ begin raise notice using message := 'foo'; end $$;"
> works and the alternative to "=" is documented in
> https://www.postgresql.org/docs/current/plpgsql-statements.html#PLPGSQL-STATEMENTS-ASSIGNMENT
> I suggest to change the grammar to
>
> USING option { := | = } expression [, ... ]
>
> for the raise statement.

I think this has been committed.
https://git.postgresql.org/cgit/postgresql.git/commit/?id=56c6be57af6bd1c7eb7dff50e5f169ced4ed3045

you can check latest doc at:
https://www.postgresql.org/docs/devel/plpgsql-errors-and-messages.html





^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: Undocumented := alternative in using option of raise statement
@ 2024-07-22 14:01  Philipp Salvisberg <philipp.salvisberg@gmail.com>
  parent: jian he <jian.universality@gmail.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Philipp Salvisberg @ 2024-07-22 14:01 UTC (permalink / raw)
  To: jian he <jian.universality@gmail.com>; +Cc: pgsql-docs@lists.postgresql.org


> On 22 Jul 2024, at 15:18, jian he <jian.universality@gmail.com> wrote:
> 
> On Mon, Jul 22, 2024 at 8:38 PM PG Doc comments form
> <noreply@postgresql.org> wrote:
>> 
>> The following documentation comment has been logged on the website:
>> 
>> Page: https://www.postgresql.org/docs/16/plpgsql-errors-and-messages.html
>> Description:
>> 
>> The using option is documented as follows for all variants of the raise
>> statement:
>> 
>> USING option = expression [, ... ]
>> 
>> However, since "do $$ begin raise notice using message := 'foo'; end $$;"
>> works and the alternative to "=" is documented in
>> https://www.postgresql.org/docs/current/plpgsql-statements.html#PLPGSQL-STATEMENTS-ASSIGNMENT
>> I suggest to change the grammar to
>> 
>> USING option { := | = } expression [, ... ]
>> 
>> for the raise statement.
> 
> I think this has been committed.
> https://git.postgresql.org/cgit/postgresql.git/commit/?id=56c6be57af6bd1c7eb7dff50e5f169ced4ed3045
> 
> you can check latest doc at:
> https://www.postgresql.org/docs/devel/plpgsql-errors-and-messages.html

Thanks Jan for letting me know. Looks good. 

Next time I'll check the devel version of the docs before submitting a correction.




^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2024-07-22 14:01 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-07-22 08:00 Undocumented := alternative in using option of raise statement PG Doc comments form <noreply@postgresql.org>
2024-07-22 13:18 ` jian he <jian.universality@gmail.com>
2024-07-22 14:01   ` Philipp Salvisberg <philipp.salvisberg@gmail.com>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox