agora inbox for pgsql-docs@postgresql.org
help / color / mirror / Atom feedElaborate on phrase "table metadata" in the Notes section of ALTER by specifying pg_attribute
2+ messages / 2 participants
[nested] [flat]
* Elaborate on phrase "table metadata" in the Notes section of ALTER by specifying pg_attribute
@ 2024-09-11 20:12 PG Doc comments form <noreply@postgresql.org>
2024-09-18 07:22 ` Re: Elaborate on phrase "table metadata" in the Notes section of ALTER by specifying pg_attribute Peter Eisentraut <peter@eisentraut.org>
0 siblings, 1 reply; 2+ messages in thread
From: PG Doc comments form @ 2024-09-11 20:12 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: amin@gilani.me
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/16/sql-altertable.html
Description:
I am newish to Postgres, and the term "table metadata" was confusing to
me.
I am more than happy to submit a patch for this. I'm just unfamiliar with
the process. Please advise.
> When a column is added with ADD COLUMN and a non-volatile DEFAULT is
specified, the default is evaluated at the time of the statement and the
result stored in the table's metadata. That value will be used for the
column for all existing rows. If no DEFAULT is specified, NULL is used. In
neither case is a rewrite of the table required.
Specifically this sentence: "the result stored in the table's metadata"
Suggest adding specific language to correct it to "the result stored in the
table's metadata. See `pg_attribute` for more information."
Once again, I am more than happy to submit a patch for this.
Thank you
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Elaborate on phrase "table metadata" in the Notes section of ALTER by specifying pg_attribute
2024-09-11 20:12 Elaborate on phrase "table metadata" in the Notes section of ALTER by specifying pg_attribute PG Doc comments form <noreply@postgresql.org>
@ 2024-09-18 07:22 ` Peter Eisentraut <peter@eisentraut.org>
0 siblings, 0 replies; 2+ messages in thread
From: Peter Eisentraut @ 2024-09-18 07:22 UTC (permalink / raw)
To: amin@gilani.me; pgsql-docs@lists.postgresql.org
On 11.09.24 22:12, PG Doc comments form wrote:
> Page:https://www.postgresql.org/docs/16/sql-altertable.html
> Description:
>
> I am newish to Postgres, and the term "table metadata" was confusing to
> me.
I think it is pretty easy to do a quick internet search to find out what
table metadata is in the context of an SQL database. Your complaint
isn't wrong in the sense that the term isn't formally defined here, but
in this case I would opt against adding more text and leave it up to the
user to do the extra research as necessary. The operation being
discussed isn't something a completely new user would immediately
encounter, after all.
>
> I am more than happy to submit a patch for this. I'm just unfamiliar with
> the process. Please advise.
>
>> When a column is added with ADD COLUMN and a non-volatile DEFAULT is
> specified, the default is evaluated at the time of the statement and the
> result stored in the table's metadata. That value will be used for the
> column for all existing rows. If no DEFAULT is specified, NULL is used. In
> neither case is a rewrite of the table required.
>
> Specifically this sentence: "the result stored in the table's metadata"
>
> Suggest adding specific language to correct it to "the result stored in the
> table's metadata. See `pg_attribute` for more information."
>
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-09-18 07:22 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-09-11 20:12 Elaborate on phrase "table metadata" in the Notes section of ALTER by specifying pg_attribute PG Doc comments form <noreply@postgresql.org>
2024-09-18 07:22 ` Peter Eisentraut <peter@eisentraut.org>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox