agora inbox for pgsql-docs@postgresql.org
help / color / mirror / Atom feedpg_createsubscriber: publication-name and subscription-name options do not exist
13+ messages / 5 participants
[nested] [flat]
* pg_createsubscriber: publication-name and subscription-name options do not exist
@ 2024-11-29 12:06 PG Doc comments form <noreply@postgresql.org>
2024-12-02 09:30 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
0 siblings, 1 reply; 13+ messages in thread
From: PG Doc comments form @ 2024-11-29 12:06 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: christophe.courtois@dalibo.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
Description:
The page https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
mentions these two options:
“If publication-name option is not specified …“
“If subscription-name is not specified …“
while `pg_createsubscriber --help` returns:
--publication=NAME publication name
--replication-slot=NAME replication slot name
--subscription=NAME subscription name
I suppose that the options should be respectively --publication and
--subscription.
Yours,
^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pg_createsubscriber: publication-name and subscription-name options do not exist
2024-11-29 12:06 pg_createsubscriber: publication-name and subscription-name options do not exist PG Doc comments form <noreply@postgresql.org>
@ 2024-12-02 09:30 ` Shubham Khanna <khannashubham1197@gmail.com>
2024-12-02 11:27 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist vignesh C <vignesh21@gmail.com>
0 siblings, 1 reply; 13+ messages in thread
From: Shubham Khanna @ 2024-12-02 09:30 UTC (permalink / raw)
To: christophe.courtois@dalibo.com; pgsql-docs@lists.postgresql.org
On Mon, Dec 2, 2024 at 2:57 PM PG Doc comments form
<noreply@postgresql.org> wrote:
>
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
> Description:
>
> The page https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
> mentions these two options:
> “If publication-name option is not specified …“
> “If subscription-name is not specified …“
>
> while `pg_createsubscriber --help` returns:
>
> --publication=NAME publication name
> --replication-slot=NAME replication slot name
> --subscription=NAME subscription name
>
> I suppose that the options should be respectively --publication and
> --subscription.
>
I have updated the Documentation for pg_createsubscriber with the
suggested changes. The attached Patch contains the required changes.
Thanks and regards,
Shubham Khanna.
Attachments:
[application/octet-stream] v1-0001-DOCS-Fix.patch (2.1K, ../../CAHv8RjL1iz=ttummTB47sNWTR3PDJVrrhf2fpTe9fZmy0Uwcvw@mail.gmail.com/2-v1-0001-DOCS-Fix.patch)
download | inline diff:
From f584ea823e01e142dfa53b7b2a0d5445df0b19b8 Mon Sep 17 00:00:00 2001
From: Khanna <Shubham.Khanna@fujitsu.com>
Date: Mon, 2 Dec 2024 14:21:16 +0530
Subject: [PATCH v1] DOCS-Fix
There is a discrepancy in the pg_createsubscriber documentation on the
PostgreSQLwebsite:
https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
The options mentioned in the documentation:- `publication-name` and
`subscription-name` do not align with the actual options provided by the tool:-
`--publication` and `--subscription`.
The changes in the Patch ensure the documentation accurately reflects the
tool's behavior and includes proper option names for clarity.
---
doc/src/sgml/ref/pg_createsubscriber.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/ref/pg_createsubscriber.sgml b/doc/src/sgml/ref/pg_createsubscriber.sgml
index 04af154c4b..9f988bac7d 100644
--- a/doc/src/sgml/ref/pg_createsubscriber.sgml
+++ b/doc/src/sgml/ref/pg_createsubscriber.sgml
@@ -407,7 +407,7 @@ PostgreSQL documentation
Create a publication and replication slot for each specified database on
the source server. Each publication is created using <link
linkend="sql-createpublication-params-for-all-tables"><literal>FOR ALL
- TABLES</literal></link>. If <option>publication-name</option> option is
+ TABLES</literal></link>. If <option>publication</option> option is
not specified, it has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameter:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
@@ -446,7 +446,7 @@ PostgreSQL documentation
<step>
<para>
Create a subscription for each specified database on the target server.
- If <option>subscription-name</option> is not specified, the subscription
+ If <option>subscription</option> is not specified, the subscription
has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameters:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
--
2.41.0.windows.3
^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pg_createsubscriber: publication-name and subscription-name options do not exist
2024-11-29 12:06 pg_createsubscriber: publication-name and subscription-name options do not exist PG Doc comments form <noreply@postgresql.org>
2024-12-02 09:30 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
@ 2024-12-02 11:27 ` vignesh C <vignesh21@gmail.com>
2024-12-02 17:32 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
0 siblings, 1 reply; 13+ messages in thread
From: vignesh C @ 2024-12-02 11:27 UTC (permalink / raw)
To: Shubham Khanna <khannashubham1197@gmail.com>; +Cc: christophe.courtois@dalibo.com, pgsql-docs@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
On Mon, 2 Dec 2024 at 15:00, Shubham Khanna <khannashubham1197@gmail.com> wrote:
>
> On Mon, Dec 2, 2024 at 2:57 PM PG Doc comments form
> <noreply@postgresql.org> wrote:
> >
> > The following documentation comment has been logged on the website:
> >
> > Page: https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
> > Description:
> >
> > The page https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
> > mentions these two options:
> > “If publication-name option is not specified …“
> > “If subscription-name is not specified …“
> >
> > while `pg_createsubscriber --help` returns:
> >
> > --publication=NAME publication name
> > --replication-slot=NAME replication slot name
> > --subscription=NAME subscription name
> >
> > I suppose that the options should be respectively --publication and
> > --subscription.
> >
>
> I have updated the Documentation for pg_createsubscriber with the
> suggested changes. The attached Patch contains the required changes.
Thanks for the patch, one suggestion:
We can change "<option>subscription</option>" to
"<option>subscription</option> option" to keep it consistent with
publication option documentation just above a few lines which mentions
it like "If <option>publication</option> option is not specified":
Create a subscription for each specified database on the target server.
- If <option>subscription-name</option> is not specified, the subscription
+ If <option>subscription</option> is not specified, the subscription
has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameters:
Regards,
Vignesh
^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pg_createsubscriber: publication-name and subscription-name options do not exist
2024-11-29 12:06 pg_createsubscriber: publication-name and subscription-name options do not exist PG Doc comments form <noreply@postgresql.org>
2024-12-02 09:30 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-02 11:27 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist vignesh C <vignesh21@gmail.com>
@ 2024-12-02 17:32 ` Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 01:45 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
0 siblings, 1 reply; 13+ messages in thread
From: Shubham Khanna @ 2024-12-02 17:32 UTC (permalink / raw)
To: vignesh C <vignesh21@gmail.com>; +Cc: christophe.courtois@dalibo.com, pgsql-docs@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
On Mon, Dec 2, 2024 at 4:57 PM vignesh C <vignesh21@gmail.com> wrote:
>
> On Mon, 2 Dec 2024 at 15:00, Shubham Khanna <khannashubham1197@gmail.com> wrote:
> >
> > On Mon, Dec 2, 2024 at 2:57 PM PG Doc comments form
> > <noreply@postgresql.org> wrote:
> > >
> > > The following documentation comment has been logged on the website:
> > >
> > > Page: https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
> > > Description:
> > >
> > > The page https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
> > > mentions these two options:
> > > “If publication-name option is not specified …“
> > > “If subscription-name is not specified …“
> > >
> > > while `pg_createsubscriber --help` returns:
> > >
> > > --publication=NAME publication name
> > > --replication-slot=NAME replication slot name
> > > --subscription=NAME subscription name
> > >
> > > I suppose that the options should be respectively --publication and
> > > --subscription.
> > >
> >
> > I have updated the Documentation for pg_createsubscriber with the
> > suggested changes. The attached Patch contains the required changes.
>
> Thanks for the patch, one suggestion:
> We can change "<option>subscription</option>" to
> "<option>subscription</option> option" to keep it consistent with
> publication option documentation just above a few lines which mentions
> it like "If <option>publication</option> option is not specified":
> Create a subscription for each specified database on the target server.
> - If <option>subscription-name</option> is not specified, the subscription
> + If <option>subscription</option> is not specified, the subscription
> has the following name pattern:
> <quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameters:
>
I have fixed the suggested changes. The attached Patch contains the
required changes.
Thanks and regards,
Shubham Khanna.
Attachments:
[application/x-patch] v2-0001-DOCS-Fix.patch (2.1K, ../../CAHv8Rj+boOi+65i8ewGtvf-VStE1F_3U2n=9iGrk-SCRHgH_ig@mail.gmail.com/2-v2-0001-DOCS-Fix.patch)
download | inline diff:
From 493d7b6cf8b8cec672186bbd6ae2717ff421e531 Mon Sep 17 00:00:00 2001
From: Khanna <Shubham.Khanna@fujitsu.com>
Date: Mon, 2 Dec 2024 14:21:16 +0530
Subject: [PATCH v2] DOCS-Fix
There is a discrepancy in the pg_createsubscriber documentation on the
PostgreSQLwebsite:
https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
The options mentioned in the documentation:- 'publication-name' and
'subscription-name' do not align with the actual options provided by the tool:-
'--publication' and '--subscription'.
The changes in the Patch ensure the documentation accurately reflects the
tool's behavior and includes proper option names for clarity.
---
doc/src/sgml/ref/pg_createsubscriber.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/src/sgml/ref/pg_createsubscriber.sgml b/doc/src/sgml/ref/pg_createsubscriber.sgml
index 04af154c4b..daeb9f6e96 100644
--- a/doc/src/sgml/ref/pg_createsubscriber.sgml
+++ b/doc/src/sgml/ref/pg_createsubscriber.sgml
@@ -407,7 +407,7 @@ PostgreSQL documentation
Create a publication and replication slot for each specified database on
the source server. Each publication is created using <link
linkend="sql-createpublication-params-for-all-tables"><literal>FOR ALL
- TABLES</literal></link>. If <option>publication-name</option> option is
+ TABLES</literal></link>. If <option>--publication</option> option is
not specified, it has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameter:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
@@ -446,7 +446,7 @@ PostgreSQL documentation
<step>
<para>
Create a subscription for each specified database on the target server.
- If <option>subscription-name</option> is not specified, the subscription
+ If <option>--subscription</option> option is not specified, the subscription
has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameters:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
--
2.41.0.windows.3
^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pg_createsubscriber: publication-name and subscription-name options do not exist
2024-11-29 12:06 pg_createsubscriber: publication-name and subscription-name options do not exist PG Doc comments form <noreply@postgresql.org>
2024-12-02 09:30 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-02 11:27 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist vignesh C <vignesh21@gmail.com>
2024-12-02 17:32 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
@ 2024-12-03 01:45 ` Peter Smith <smithpb2250@gmail.com>
2024-12-03 03:09 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
0 siblings, 1 reply; 13+ messages in thread
From: Peter Smith @ 2024-12-03 01:45 UTC (permalink / raw)
To: Shubham Khanna <khannashubham1197@gmail.com>; +Cc: vignesh C <vignesh21@gmail.com>; christophe.courtois@dalibo.com, pgsql-docs@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
Hi Shubham,
I took a look at the patch v2-0001. Here are some review comments.
1.
Previously when this DOCS page was referring to the --publication and
--subscription it was calling those "switches". I don't know why, but
it does.
Maybe calling them "options" is ok too, but personally (for
consistency with the above) I would've stuck with the same "switches"
terminology.
1a.
/If --publication option is not specified.../If the --publication
switch is not specified.../
or maybe just omit the term entirely
/If --publication option is not specified.../If --publication is not
specified.../
~
1b.
/If --subscription option is not specified.../If the --subscription
switch is not specified.../
or maybe just omit the term entirely
/If --subscription option is not specified.../If --subscription is not
specified.../
~~~
2.
Although the patch addresses the reported problems, I think the same
problem exists for "replication-slot-name". e.g. the DOCS are saying
"If replication-slot-name is not specified..." although there is no
such thing -- it is called "--replication-slot"
So, the patch should also be fixing that one using the same consistent wording.
e.g.
/If replication-slot-name is not specified.../If the
--replication-slot switch is not specified.../
or
/If replication-slot-name is not specified.../If --replication-slot is
not specified.../
======
Kind Regards,
Peter Smith.
Fujitsu Australia
^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pg_createsubscriber: publication-name and subscription-name options do not exist
2024-11-29 12:06 pg_createsubscriber: publication-name and subscription-name options do not exist PG Doc comments form <noreply@postgresql.org>
2024-12-02 09:30 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-02 11:27 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist vignesh C <vignesh21@gmail.com>
2024-12-02 17:32 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 01:45 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
@ 2024-12-03 03:09 ` Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:28 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
0 siblings, 1 reply; 13+ messages in thread
From: Shubham Khanna @ 2024-12-03 03:09 UTC (permalink / raw)
To: Peter Smith <smithpb2250@gmail.com>; +Cc: vignesh C <vignesh21@gmail.com>; christophe.courtois@dalibo.com, pgsql-docs@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
On Tue, Dec 3, 2024 at 7:16 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Shubham,
>
> I took a look at the patch v2-0001. Here are some review comments.
>
> 1.
> Previously when this DOCS page was referring to the --publication and
> --subscription it was calling those "switches". I don't know why, but
> it does.
>
> Maybe calling them "options" is ok too, but personally (for
> consistency with the above) I would've stuck with the same "switches"
> terminology.
>
> 1a.
> /If --publication option is not specified.../If the --publication
> switch is not specified.../
>
> or maybe just omit the term entirely
> /If --publication option is not specified.../If --publication is not
> specified.../
>
> ~
>
> 1b.
> /If --subscription option is not specified.../If the --subscription
> switch is not specified.../
>
> or maybe just omit the term entirely
> /If --subscription option is not specified.../If --subscription is not
> specified.../
>
> ~~~
>
> 2.
> Although the patch addresses the reported problems, I think the same
> problem exists for "replication-slot-name". e.g. the DOCS are saying
> "If replication-slot-name is not specified..." although there is no
> such thing -- it is called "--replication-slot"
>
> So, the patch should also be fixing that one using the same consistent wording.
>
> e.g.
> /If replication-slot-name is not specified.../If the
> --replication-slot switch is not specified.../
> or
> /If replication-slot-name is not specified.../If --replication-slot is
> not specified.../
>
I have fixed the suggested changes. The attached Patch contains the
required changes.
Thanks and regards,
Shubham Khanna.
Attachments:
[application/octet-stream] v3-0001-DOCS-Fix.patch (2.5K, ../../CAHv8RjLgprT5gzZT-DynagOT3099Q3Z=shrioA6Pt3QZeVcXFQ@mail.gmail.com/2-v3-0001-DOCS-Fix.patch)
download | inline diff:
From b9f588e64fcfa87428b80627a9bb4e0a219e9d1d Mon Sep 17 00:00:00 2001
From: Khanna <Shubham.Khanna@fujitsu.com>
Date: Mon, 2 Dec 2024 14:21:16 +0530
Subject: [PATCH v3] DOCS-Fix
There is a discrepancy in the pg_createsubscriber documentation on the
PostgreSQLwebsite:
https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
The options mentioned in the documentation:- 'publication-name' and
'subscription-name' do not align with the actual options provided by the tool:-
'--publication' and '--subscription'.
The changes in the Patch ensure the documentation accurately reflects the
tool's behavior and includes proper option names for clarity.
---
doc/src/sgml/ref/pg_createsubscriber.sgml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/src/sgml/ref/pg_createsubscriber.sgml b/doc/src/sgml/ref/pg_createsubscriber.sgml
index 04af154c4b..f60f0b7cdc 100644
--- a/doc/src/sgml/ref/pg_createsubscriber.sgml
+++ b/doc/src/sgml/ref/pg_createsubscriber.sgml
@@ -407,11 +407,11 @@ PostgreSQL documentation
Create a publication and replication slot for each specified database on
the source server. Each publication is created using <link
linkend="sql-createpublication-params-for-all-tables"><literal>FOR ALL
- TABLES</literal></link>. If <option>publication-name</option> option is
+ TABLES</literal></link>. If the <option>--publication</option> switch is
not specified, it has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameter:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
- If <option>replication-slot-name</option> is not specified, the
+ If the <option>--replication-slot-name</option> switch is not specified, the
replication slot has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameters:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
@@ -446,7 +446,7 @@ PostgreSQL documentation
<step>
<para>
Create a subscription for each specified database on the target server.
- If <option>subscription-name</option> is not specified, the subscription
+ If the <option>--subscription</option> switch is not specified, the subscription
has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameters:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
--
2.41.0.windows.3
^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pg_createsubscriber: publication-name and subscription-name options do not exist
2024-11-29 12:06 pg_createsubscriber: publication-name and subscription-name options do not exist PG Doc comments form <noreply@postgresql.org>
2024-12-02 09:30 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-02 11:27 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist vignesh C <vignesh21@gmail.com>
2024-12-02 17:32 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 01:45 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 03:09 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
@ 2024-12-03 03:28 ` Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:50 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
0 siblings, 1 reply; 13+ messages in thread
From: Shubham Khanna @ 2024-12-03 03:28 UTC (permalink / raw)
To: Peter Smith <smithpb2250@gmail.com>; +Cc: vignesh C <vignesh21@gmail.com>; christophe.courtois@dalibo.com, pgsql-docs@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
On Tue, Dec 3, 2024 at 8:39 AM Shubham Khanna
<khannashubham1197@gmail.com> wrote:
>
> On Tue, Dec 3, 2024 at 7:16 AM Peter Smith <smithpb2250@gmail.com> wrote:
> >
> > Hi Shubham,
> >
> > I took a look at the patch v2-0001. Here are some review comments.
> >
> > 1.
> > Previously when this DOCS page was referring to the --publication and
> > --subscription it was calling those "switches". I don't know why, but
> > it does.
> >
> > Maybe calling them "options" is ok too, but personally (for
> > consistency with the above) I would've stuck with the same "switches"
> > terminology.
> >
> > 1a.
> > /If --publication option is not specified.../If the --publication
> > switch is not specified.../
> >
> > or maybe just omit the term entirely
> > /If --publication option is not specified.../If --publication is not
> > specified.../
> >
> > ~
> >
> > 1b.
> > /If --subscription option is not specified.../If the --subscription
> > switch is not specified.../
> >
> > or maybe just omit the term entirely
> > /If --subscription option is not specified.../If --subscription is not
> > specified.../
> >
> > ~~~
> >
> > 2.
> > Although the patch addresses the reported problems, I think the same
> > problem exists for "replication-slot-name". e.g. the DOCS are saying
> > "If replication-slot-name is not specified..." although there is no
> > such thing -- it is called "--replication-slot"
> >
> > So, the patch should also be fixing that one using the same consistent wording.
> >
> > e.g.
> > /If replication-slot-name is not specified.../If the
> > --replication-slot switch is not specified.../
> > or
> > /If replication-slot-name is not specified.../If --replication-slot is
> > not specified.../
> >
>
> I have fixed the suggested changes. The attached Patch contains the
> required changes.
>
I have omitted the 'switch' from the suggested places to ensure
consistency within the documentation. The attached patch includes the
updated changes.
Thanks and regards,
Shubham Khanna.
Attachments:
[application/octet-stream] v4-0001-DOCS-Fix.patch (2.5K, ../../CAHv8Rj+doEWrP8dXN96D4zFVjmZxKdVnt+=RuwxpDL5Y95tZQw@mail.gmail.com/2-v4-0001-DOCS-Fix.patch)
download | inline diff:
From aaeaf47f5e3fea01d5741daeda804c9cd080b453 Mon Sep 17 00:00:00 2001
From: Khanna <Shubham.Khanna@fujitsu.com>
Date: Mon, 2 Dec 2024 14:21:16 +0530
Subject: [PATCH v4] DOCS-Fix
There is a discrepancy in the pg_createsubscriber documentation on the
PostgreSQLwebsite:
https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
The options mentioned in the documentation:- 'publication-name' and
'subscription-name' do not align with the actual options provided by the tool:-
'--publication' and '--subscription'.
The changes in the Patch ensure the documentation accurately reflects the
tool's behavior and includes proper option names for clarity.
---
doc/src/sgml/ref/pg_createsubscriber.sgml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/src/sgml/ref/pg_createsubscriber.sgml b/doc/src/sgml/ref/pg_createsubscriber.sgml
index 04af154c4b..d6b89fe273 100644
--- a/doc/src/sgml/ref/pg_createsubscriber.sgml
+++ b/doc/src/sgml/ref/pg_createsubscriber.sgml
@@ -407,11 +407,11 @@ PostgreSQL documentation
Create a publication and replication slot for each specified database on
the source server. Each publication is created using <link
linkend="sql-createpublication-params-for-all-tables"><literal>FOR ALL
- TABLES</literal></link>. If <option>publication-name</option> option is
- not specified, it has the following name pattern:
+ TABLES</literal></link>. If the <option>--publication</option> is not
+ specified, it has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameter:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
- If <option>replication-slot-name</option> is not specified, the
+ If the <option>--replication-slot-name</option> is not specified, the
replication slot has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameters:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
@@ -446,7 +446,7 @@ PostgreSQL documentation
<step>
<para>
Create a subscription for each specified database on the target server.
- If <option>subscription-name</option> is not specified, the subscription
+ If the <option>--subscription</option> is not specified, the subscription
has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameters:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
--
2.41.0.windows.3
^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pg_createsubscriber: publication-name and subscription-name options do not exist
2024-11-29 12:06 pg_createsubscriber: publication-name and subscription-name options do not exist PG Doc comments form <noreply@postgresql.org>
2024-12-02 09:30 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-02 11:27 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist vignesh C <vignesh21@gmail.com>
2024-12-02 17:32 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 01:45 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 03:09 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:28 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
@ 2024-12-03 03:50 ` Peter Smith <smithpb2250@gmail.com>
2024-12-03 04:22 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
0 siblings, 1 reply; 13+ messages in thread
From: Peter Smith @ 2024-12-03 03:50 UTC (permalink / raw)
To: Shubham Khanna <khannashubham1197@gmail.com>; +Cc: vignesh C <vignesh21@gmail.com>; christophe.courtois@dalibo.com, pgsql-docs@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
Hi Shubham,
Here are my comments for v4-0001.
1.
- If <option>replication-slot-name</option> is not specified, the
+ If the <option>--replication-slot-name</option> is not specified, the
No. I already said before ([1] #2) that there is no such thing called
"--replication-slot-name". It should be called "--replication-slot"
~~~
2.
FYI your v4 changes are not using the text that I had suggested in
[1]. E.g. When the switch/option term is not included I felt it was
better to omit the word "the". Maybe you changed that deliberately, in
which case that is your choice, but TBH I suspect this may have been
unintentional.
IMO it should look like this.
/If the <option>--publication</option> is not specified/If
<option>--publication</option> is not specified/
/If the <option>--replication-slot-name</option> is not specified/If
<option>--replication-slot</option> is not specified/
/If the <option>--subscription</option> is not specified/If
<option>--subscription</option> is not specified/
======
[1] https://www.postgresql.org/message-id/CAHut%2BPs8Xq-e5XL%3DAejiX-pF0417Vc7tMrh%2BYuZjBt7ozjvPUA%40ma...
Kind Regards,
Peter Smith.
Fujitsu Australia
^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pg_createsubscriber: publication-name and subscription-name options do not exist
2024-11-29 12:06 pg_createsubscriber: publication-name and subscription-name options do not exist PG Doc comments form <noreply@postgresql.org>
2024-12-02 09:30 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-02 11:27 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist vignesh C <vignesh21@gmail.com>
2024-12-02 17:32 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 01:45 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 03:09 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:28 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:50 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
@ 2024-12-03 04:22 ` Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 04:54 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
0 siblings, 1 reply; 13+ messages in thread
From: Shubham Khanna @ 2024-12-03 04:22 UTC (permalink / raw)
To: Peter Smith <smithpb2250@gmail.com>; +Cc: vignesh C <vignesh21@gmail.com>; christophe.courtois@dalibo.com, pgsql-docs@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
On Tue, Dec 3, 2024 at 9:21 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Shubham,
>
> Here are my comments for v4-0001.
>
> 1.
> - If <option>replication-slot-name</option> is not specified, the
> + If the <option>--replication-slot-name</option> is not specified, the
>
> No. I already said before ([1] #2) that there is no such thing called
> "--replication-slot-name". It should be called "--replication-slot"
>
> ~~~
>
> 2.
> FYI your v4 changes are not using the text that I had suggested in
> [1]. E.g. When the switch/option term is not included I felt it was
> better to omit the word "the". Maybe you changed that deliberately, in
> which case that is your choice, but TBH I suspect this may have been
> unintentional.
>
> IMO it should look like this.
>
> /If the <option>--publication</option> is not specified/If
> <option>--publication</option> is not specified/
>
> /If the <option>--replication-slot-name</option> is not specified/If
> <option>--replication-slot</option> is not specified/
>
> /If the <option>--subscription</option> is not specified/If
> <option>--subscription</option> is not specified/
>
> ======
> [1] https://www.postgresql.org/message-id/CAHut%2BPs8Xq-e5XL%3DAejiX-pF0417Vc7tMrh%2BYuZjBt7ozjvPUA%40ma...
>
I have fixed the suggested changes. The attached Patch contains the
required changes.
Thanks and regards,
Shubham Khanna.
Attachments:
[application/octet-stream] v5-0001-DOCS-Fix.patch (2.5K, ../../CAHv8RjJD9PgKLfEJQzmBL4faTPdq7uaOxiVOKVUOkYGrF8a9gg@mail.gmail.com/2-v5-0001-DOCS-Fix.patch)
download | inline diff:
From 116a164f5a9e1d27b254bd39c3c2d56698ee42eb Mon Sep 17 00:00:00 2001
From: Khanna <Shubham.Khanna@fujitsu.com>
Date: Mon, 2 Dec 2024 14:21:16 +0530
Subject: [PATCH v5] DOCS-Fix
There is a discrepancy in the pg_createsubscriber documentation on the
PostgreSQLwebsite:
https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
The options mentioned in the documentation:- 'publication-name' and
'subscription-name' do not align with the actual options provided by the tool:-
'--publication' and '--subscription'.
The changes in the Patch ensure the documentation accurately reflects the
tool's behavior and includes proper option names for clarity.
---
doc/src/sgml/ref/pg_createsubscriber.sgml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/src/sgml/ref/pg_createsubscriber.sgml b/doc/src/sgml/ref/pg_createsubscriber.sgml
index 04af154c4b..d45fb828d8 100644
--- a/doc/src/sgml/ref/pg_createsubscriber.sgml
+++ b/doc/src/sgml/ref/pg_createsubscriber.sgml
@@ -407,11 +407,11 @@ PostgreSQL documentation
Create a publication and replication slot for each specified database on
the source server. Each publication is created using <link
linkend="sql-createpublication-params-for-all-tables"><literal>FOR ALL
- TABLES</literal></link>. If <option>publication-name</option> option is
- not specified, it has the following name pattern:
+ TABLES</literal></link>. If <option>--publication</option> is not
+ specified, it has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameter:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
- If <option>replication-slot-name</option> is not specified, the
+ If <option>--replication-slot</option> is not specified, the
replication slot has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameters:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
@@ -446,7 +446,7 @@ PostgreSQL documentation
<step>
<para>
Create a subscription for each specified database on the target server.
- If <option>subscription-name</option> is not specified, the subscription
+ If <option>--subscription</option> is not specified, the subscription
has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameters:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
--
2.41.0.windows.3
^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pg_createsubscriber: publication-name and subscription-name options do not exist
2024-11-29 12:06 pg_createsubscriber: publication-name and subscription-name options do not exist PG Doc comments form <noreply@postgresql.org>
2024-12-02 09:30 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-02 11:27 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist vignesh C <vignesh21@gmail.com>
2024-12-02 17:32 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 01:45 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 03:09 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:28 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:50 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 04:22 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
@ 2024-12-03 04:54 ` Peter Smith <smithpb2250@gmail.com>
2024-12-03 05:11 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
0 siblings, 1 reply; 13+ messages in thread
From: Peter Smith @ 2024-12-03 04:54 UTC (permalink / raw)
To: Shubham Khanna <khannashubham1197@gmail.com>; +Cc: vignesh C <vignesh21@gmail.com>; christophe.courtois@dalibo.com, pgsql-docs@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
Hi Shubham,
The patch v5-0001 looks mostly OK to me (visual inspection only).
But, I did notice one other improvement you could make in passing.
1.
- TABLES</literal></link>. If <option>publication-name</option> option is
- not specified, it has the following name pattern:
+ TABLES</literal></link>. If <option>--publication</option> is not
+ specified, it has the following name pattern:
Instead of saying "it has the following name pattern:", IMO it is better to say:
"the publication has the following name pattern:".
That would make it consistent with the similar sentences which are saying:
"... the replication slot has the following name pattern:
"... the subscription has the following name pattern:"
======
Kind Regards,
Peter Smith.
Fujitsu Australia
^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pg_createsubscriber: publication-name and subscription-name options do not exist
2024-11-29 12:06 pg_createsubscriber: publication-name and subscription-name options do not exist PG Doc comments form <noreply@postgresql.org>
2024-12-02 09:30 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-02 11:27 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist vignesh C <vignesh21@gmail.com>
2024-12-02 17:32 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 01:45 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 03:09 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:28 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:50 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 04:22 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 04:54 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
@ 2024-12-03 05:11 ` Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 05:58 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
0 siblings, 1 reply; 13+ messages in thread
From: Shubham Khanna @ 2024-12-03 05:11 UTC (permalink / raw)
To: Peter Smith <smithpb2250@gmail.com>; +Cc: vignesh C <vignesh21@gmail.com>; christophe.courtois@dalibo.com, pgsql-docs@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
On Tue, Dec 3, 2024 at 10:25 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Shubham,
>
> The patch v5-0001 looks mostly OK to me (visual inspection only).
>
> But, I did notice one other improvement you could make in passing.
>
> 1.
> - TABLES</literal></link>. If <option>publication-name</option> option is
> - not specified, it has the following name pattern:
> + TABLES</literal></link>. If <option>--publication</option> is not
> + specified, it has the following name pattern:
>
> Instead of saying "it has the following name pattern:", IMO it is better to say:
> "the publication has the following name pattern:".
>
> That would make it consistent with the similar sentences which are saying:
> "... the replication slot has the following name pattern:
> "... the subscription has the following name pattern:"
>
I have added the suggested change. The attached Patch contains the
required changes.
Thanks and regards,
Shubham Khanna.
Attachments:
[application/octet-stream] v6-0001-DOCS-Fix.patch (2.5K, ../../CAHv8RjJ8EDnphOBQP9+DK7_SebQvabpgzjW2VfVQNh8-=hv9QA@mail.gmail.com/2-v6-0001-DOCS-Fix.patch)
download | inline diff:
From 1efda8a425662930f20ebf2ba97e89ee3fdef6ee Mon Sep 17 00:00:00 2001
From: Khanna <Shubham.Khanna@fujitsu.com>
Date: Mon, 2 Dec 2024 14:21:16 +0530
Subject: [PATCH v6] DOCS-Fix
There is a discrepancy in the pg_createsubscriber documentation on the
PostgreSQLwebsite:
https://www.postgresql.org/docs/17/app-pgcreatesubscriber.html
The options mentioned in the documentation:- 'publication-name' and
'subscription-name' do not align with the actual options provided by the tool:-
'--publication' and '--subscription'.
The changes in the Patch ensure the documentation accurately reflects the
tool's behavior and includes proper option names for clarity.
---
doc/src/sgml/ref/pg_createsubscriber.sgml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/src/sgml/ref/pg_createsubscriber.sgml b/doc/src/sgml/ref/pg_createsubscriber.sgml
index 04af154c4b..3159a1b60a 100644
--- a/doc/src/sgml/ref/pg_createsubscriber.sgml
+++ b/doc/src/sgml/ref/pg_createsubscriber.sgml
@@ -407,11 +407,11 @@ PostgreSQL documentation
Create a publication and replication slot for each specified database on
the source server. Each publication is created using <link
linkend="sql-createpublication-params-for-all-tables"><literal>FOR ALL
- TABLES</literal></link>. If <option>publication-name</option> option is
- not specified, it has the following name pattern:
+ TABLES</literal></link>. If <option>--publication</option> is not
+ specified, the publication has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameter:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
- If <option>replication-slot-name</option> is not specified, the
+ If <option>--replication-slot</option> is not specified, the
replication slot has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameters:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
@@ -446,7 +446,7 @@ PostgreSQL documentation
<step>
<para>
Create a subscription for each specified database on the target server.
- If <option>subscription-name</option> is not specified, the subscription
+ If <option>--subscription</option> is not specified, the subscription
has the following name pattern:
<quote><literal>pg_createsubscriber_%u_%x</literal></quote> (parameters:
database <parameter>oid</parameter>, random <parameter>int</parameter>).
--
2.41.0.windows.3
^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pg_createsubscriber: publication-name and subscription-name options do not exist
2024-11-29 12:06 pg_createsubscriber: publication-name and subscription-name options do not exist PG Doc comments form <noreply@postgresql.org>
2024-12-02 09:30 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-02 11:27 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist vignesh C <vignesh21@gmail.com>
2024-12-02 17:32 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 01:45 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 03:09 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:28 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:50 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 04:22 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 04:54 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 05:11 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
@ 2024-12-03 05:58 ` Peter Smith <smithpb2250@gmail.com>
2024-12-03 07:23 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 13+ messages in thread
From: Peter Smith @ 2024-12-03 05:58 UTC (permalink / raw)
To: Shubham Khanna <khannashubham1197@gmail.com>; +Cc: vignesh C <vignesh21@gmail.com>; christophe.courtois@dalibo.com, pgsql-docs@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
Patch v6-0001 LGTM.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
^ permalink raw reply [nested|flat] 13+ messages in thread
* Re: pg_createsubscriber: publication-name and subscription-name options do not exist
2024-11-29 12:06 pg_createsubscriber: publication-name and subscription-name options do not exist PG Doc comments form <noreply@postgresql.org>
2024-12-02 09:30 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-02 11:27 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist vignesh C <vignesh21@gmail.com>
2024-12-02 17:32 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 01:45 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 03:09 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:28 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:50 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 04:22 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 04:54 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 05:11 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 05:58 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
@ 2024-12-03 07:23 ` Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 13+ messages in thread
From: Michael Paquier @ 2024-12-03 07:23 UTC (permalink / raw)
To: Peter Smith <smithpb2250@gmail.com>; +Cc: Shubham Khanna <khannashubham1197@gmail.com>; vignesh C <vignesh21@gmail.com>; christophe.courtois@dalibo.com, pgsql-docs@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
On Tue, Dec 03, 2024 at 04:58:04PM +1100, Peter Smith wrote:
> Patch v6-0001 LGTM.
Right, it's true that this is a bit confusing when worded with terms
that are not in the description of the command.
The docs tend to prefer "the <option>--foo</option> option" when
referring to a specific switch in the notes section of a tool. I've
just used that, and applied the patch down to v17. Thanks!
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../Z06x874RHQR1iYnq@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 13+ messages in thread
end of thread, other threads:[~2024-12-03 07:23 UTC | newest]
Thread overview: 13+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-11-29 12:06 pg_createsubscriber: publication-name and subscription-name options do not exist PG Doc comments form <noreply@postgresql.org>
2024-12-02 09:30 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-02 11:27 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist vignesh C <vignesh21@gmail.com>
2024-12-02 17:32 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 01:45 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 03:09 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:28 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 03:50 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 04:22 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 04:54 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 05:11 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Shubham Khanna <khannashubham1197@gmail.com>
2024-12-03 05:58 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Peter Smith <smithpb2250@gmail.com>
2024-12-03 07:23 ` Re: pg_createsubscriber: publication-name and subscription-name options do not exist Michael Paquier <michael@paquier.xyz>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox