public inbox for [email protected]
help / color / mirror / Atom feedError in 18.4 release notes
2+ messages / 2 participants
[nested] [flat]
* Error in 18.4 release notes
@ 2026-05-15 09:15 PG Doc comments form <[email protected]>
2026-05-15 22:13 ` Re: Error in 18.4 release notes Tom Lane <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: PG Doc comments form @ 2026-05-15 09:15 UTC (permalink / raw)
To: [email protected]; +Cc: [email protected]
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/18/release-18-4.html
Description:
The 18.4 release notes say this: "Use timing-safe string comparisons in
authentication code (Michael Paquier) Use timingsafe_bcmp() instead of
memcpy() or strcmp() when checking passwords, ..."
I think that should be memcmp() instead of memcpy().
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Error in 18.4 release notes
2026-05-15 09:15 Error in 18.4 release notes PG Doc comments form <[email protected]>
@ 2026-05-15 22:13 ` Tom Lane <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Tom Lane @ 2026-05-15 22:13 UTC (permalink / raw)
To: [email protected]; +Cc: [email protected]
PG Doc comments form <[email protected]> writes:
> The 18.4 release notes say this: "Use timing-safe string comparisons in
> authentication code (Michael Paquier) Use timingsafe_bcmp() instead of
> memcpy() or strcmp() when checking passwords, ..."
> I think that should be memcmp() instead of memcpy().
Sigh, you're right --- that's my thinko. Will fix in git for posterity's
sake, though the notes are already out and probably no-one will care
anymore by the time of the next release.
regards, tom lane
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-05-15 22:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-05-15 09:15 Error in 18.4 release notes PG Doc comments form <[email protected]>
2026-05-15 22:13 ` Tom Lane <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox