Received: from localhost (unknown [200.46.204.183]) by postgresql.org (Postfix) with ESMTP id 288FC9F9A40 for ; Sun, 9 Sep 2007 12:10:48 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 19621-01 for ; Sun, 9 Sep 2007 12:10:45 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.5 Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id 0BD259F99EA for ; Sun, 9 Sep 2007 12:10:44 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.1/8.14.1) with ESMTP id l89FAeA9018347; Sun, 9 Sep 2007 11:10:40 -0400 (EDT) To: Oleg Bartunov cc: Gregory Stark , Pavel Stehule , PostgreSQL Hackers Subject: Re: tsearch filenames unlikes special symbols and numbers In-reply-to: References: <162867790709021328i7771aa9jfe79268bccbf123d@mail.gmail.com> <18259.1188773171@sss.pgh.pa.us> <87y7foir7t.fsf@oxford.xeocode.com> <19257.1188777110@sss.pgh.pa.us> Comments: In-reply-to Oleg Bartunov message dated "Sun, 09 Sep 2007 08:38:37 +0400" Date: Sun, 09 Sep 2007 11:10:40 -0400 Message-ID: <18346.1189350640@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200709/383 X-Sequence-Number: 107535 Oleg Bartunov writes: > Oh, my god, I see we dictate extensions ! > Folk, this is too much ! Now, we dictate extensions '.dict, .affix, .stop', > what else ? > Does it defined by ispell template only, or it's global requirements ? It's the callers of get_tsearch_config_filename() that specify the extension, so AFAICS each dictionary can do what it wants. I don't see the problem with enforcing an extension: it keeps the namespaces for different kinds of files separate, and it gets us out of the potential security risk of allowing access to "." or "..". I remain of the opinion that we don't really want the SQL-command definitions of dictionaries to expose the fact that these are files at all. We should be thinking of the command parameters as identifiers. regards, tom lane