Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M249898=pgsql-hackers-arkari@postgresql.org>)
 id 1WiibX-0002J4-5j
 for pgsql-hackers@arkaria.postgresql.org; Fri, 09 May 2014 11:04:39 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M249898=pgsql-hackers-arkari@postgresql.org>)
 id 1WiibW-00013c-LO
 for pgsql-hackers@arkaria.postgresql.org; Fri, 09 May 2014 11:04:38 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
 by malur.postgresql.org with esmtp (Exim 4.80)
 (envelope-from <tgl@sss.pgh.pa.us>) id 1WiibV-00013Q-Kr
 for pgsql-hackers@postgresql.org; Fri, 09 May 2014 11:04:37 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
 by magus.postgresql.org with esmtp (Exim 4.80)
 (envelope-from <tgl@sss.pgh.pa.us>) id 1WiibS-0004qp-PA
 for pgsql-hackers@postgresql.org; Fri, 09 May 2014 11:04:37 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
 by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id s49B4HY5018361;
 Fri, 9 May 2014 07:04:18 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Gavin Flower <GavinFlower@archidevsys.co.nz>
cc: Bruce Momjian <bruce@momjian.us>,
 "David E. Wheeler" <david@justatheory.com>, Greg Stark <stark@mit.edu>,
 Robert Haas <robertmhaas@gmail.com>,
 Heikki Linnakangas <hlinnakangas@vmware.com>,
 Andrew Dunstan <andrew@dunslane.net>, Peter Geoghegan <pg@heroku.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: default opclass for jsonb (was Re: Call for GIST/GIN/SP-GIST
 opclass documentation)
In-reply-to: <536C550F.50108@archidevsys.co.nz>
References: <20140422223230.GL10046@momjian.us>
 <16527.1398214220@sss.pgh.pa.us> <20140506201048.GI30817@momjian.us>
 <16769.1399407530@sss.pgh.pa.us> <20140506212020.GK30817@momjian.us>
 <57E8AA44-F816-45F2-BB61-5A854FFB0A97@justatheory.com>
 <28554.1399414853@sss.pgh.pa.us> <20140508134701.GO30817@momjian.us>
 <5819.1399558614@sss.pgh.pa.us> <1888.1399588751@sss.pgh.pa.us>
 <20140509033405.GA23254@momjian.us> <536C550F.50108@archidevsys.co.nz>
Comments: In-reply-to Gavin Flower <GavinFlower@archidevsys.co.nz>
 message dated "Fri, 09 May 2014 16:09:51 +1200"
Date: Fri, 09 May 2014 07:04:17 -0400
Message-ID: <18360.1399633457@sss.pgh.pa.us>
X-Pg-Spam-Score: -2.6 (--)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Gavin Flower <GavinFlower@archidevsys.co.nz> writes:
> On 09/05/14 15:34, Bruce Momjian wrote:
>> Looks good.  I was thinking the jsonb_ops name could remain unchanged
>> and the jsonb_hash_ops could be called jsonb_combo_ops as it combines
>> the key and value into a single index entry.

> If you have 'jsonb_combo_ops' - then surely 'jsonb_op' should be called 
> 'jsonb_xxx_ops', where the 'xxx' distinguishes that from 
> 'jsonb_combo_ops'?  I guess, if any appropriate wording of 'xxx' was too 
> cumbersome, then it would be worse.

Yeah, I'm disinclined to change the opclass names now.  It's not apparent
to me that "combo" is a better choice than "hash" for the second opclass.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers