X-Original-To: pgsql-docs-postgresql.org@postgresql.org Received: from localhost (mx1.hub.org [200.46.208.251]) by postgresql.org (Postfix) with ESMTP id D740E9FB27A; Thu, 3 Aug 2006 11:58:23 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.208.251]) (amavisd-new, port 10024) with ESMTP id 32130-10; Thu, 3 Aug 2006 11:58:17 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey- X-Greylist: from auto-whitelisted by SQLgrey- Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130]) by postgresql.org (Postfix) with ESMTP id 4AE009FB274; Thu, 3 Aug 2006 11:58:19 -0300 (ADT) Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.13.6/8.13.6) with ESMTP id k73EwASk018686; Thu, 3 Aug 2006 10:58:11 -0400 (EDT) To: Gavin Sherry cc: Joe Conway , pgsql-patches@postgresql.org, pgsql-docs@postgresql.org Subject: Re: Values list-of-targetlists patch for comments (was Re: [PATCHES] In-reply-to: References: <44B69778.5050104@dunslane.net> <44B7ADFC.90205@dunslane.net> <44BC0432.3040509@joeconway.com> <44BC661F.80609@joeconway.com> <44CFFD2D.8040906@joeconway.com> Comments: In-reply-to Gavin Sherry message dated "Thu, 03 Aug 2006 15:31:06 +1000" Date: Thu, 03 Aug 2006 10:58:10 -0400 Message-ID: <18685.1154617090@sss.pgh.pa.us> From: Tom Lane X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.171 tagged_above=0 required=5 tests=AWL, SPF_HELO_PASS, SPF_PASS X-Spam-Level: X-Archive-Number: 200608/3 X-Sequence-Number: 3621 Gavin Sherry writes: > Docs and regression tests attached. I've applied the regression tests (with a few additions), but I'm feeling dissatisfied with this approach to documenting VALUES. It seems to be mostly missing the point about VALUES being usable whereever SELECT is. I'm not at all sure what I'd do instead though. Should we give VALUES its own reference page? That doesn't quite seem helpful either. cc'ing to pgsql-docs for ideas. regards, tom lane