Received: from makus.postgresql.org (makus.postgresql.org [98.129.198.125]) by mail.postgresql.org (Postfix) with ESMTP id 4C6A313CDD72 for ; Sun, 29 Apr 2012 18:06:25 -0300 (ADT) Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtp (Exim 4.72) (envelope-from ) id 1SObK3-0001Bv-7M for pgsql-docs@postgresql.org; Sun, 29 Apr 2012 21:06:24 +0000 Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id q3TL693I019137; Sun, 29 Apr 2012 17:06:09 -0400 (EDT) To: Josh Kupershmidt cc: pgsql-docs@postgresql.org Subject: Re: Documentation of underlying functions for statistics views In-reply-to: References: <4683.1335648276@sss.pgh.pa.us> <23280.1335711812@sss.pgh.pa.us> Comments: In-reply-to Josh Kupershmidt message dated "Sun, 29 Apr 2012 11:56:30 -0700" Date: Sun, 29 Apr 2012 17:06:09 -0400 Message-ID: <19136.1335733569@sss.pgh.pa.us> From: Tom Lane X-Pg-Spam-Score: -1.9 (-) X-Archive-Number: 201204/65 X-Sequence-Number: 7319 Josh Kupershmidt writes: > Yeah, that sounds fine. The paragraph I think you're talking about > claims "These functions are listed in Table 27-13", but Table 27-13 > only has a few functions (e.g. pg_stat_get_db_block_time_read() is > missing). Maybe that paragraph could clarify that it's talking > generally about all the views/functions on that page. It seemed to me that the only view-underlying function that needs explicit documentation is pg_stat_get_activity(), because the fact that you can pass it a PID isn't obvious from the view's usage. So that's the only one I left in table 27-13. However, I realized that the stats functions that we used in pg_stat_activity before 8.4 are not documented at all with this approach, so I made another table 27-14 to cover them. I'm not sure if we should mark them deprecated or not; thoughts? Anyway, this is committed and up on the devel docs website, if you want to take a look. regards, tom lane