To: Gregory Stark <stark@enterprisedb.com>
cc: "Oleg Bartunov" <oleg@sai.msu.su>,
	"Pavel Stehule" <pavel.stehule@gmail.com>,
	"PostgreSQL Hackers" <pgsql-hackers@postgresql.org>
Subject: Re: tsearch filenames unlikes special symbols and numbers 
In-reply-to: <87y7foir7t.fsf@oxford.xeocode.com> 
References: <162867790709021328i7771aa9jfe79268bccbf123d@mail.gmail.com>
	<Pine.LNX.4.64.0709030113090.2767@sn.sai.msu.ru>
	<18259.1188773171@sss.pgh.pa.us>
	<87y7foir7t.fsf@oxford.xeocode.com>
Comments: In-reply-to Gregory Stark <stark@enterprisedb.com>
	message dated "Mon, 03 Sep 2007 00:26:46 +0100"
Date: Sun, 02 Sep 2007 19:51:50 -0400
Message-ID: <19257.1188777110@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

Gregory Stark <stark@enterprisedb.com> writes:
> "Tom Lane" <tgl@sss.pgh.pa.us> writes:
>> I made it reject all but latin letters, which is the same restriction
>> that's in place for timezone set filenames.  That might be overly
>> strong, but we definitely have to forbid "." and "/" (and "\" on
>> Windows).  Do we want to restrict it to letters, digits, underscore?
>> Or does it need to be weaker than that?

> What's the problem with "."?

../../../../etc/passwd

Possibly we could allow '.' as long as we forbade /, but the other
trouble with allowing . is that it encourages people to try to specify
the filetype suffix (as indeed Oleg was doing).  I'd prefer to keep the
suffixes out of the SQL object definitions, with an eye to possibly
someday migrating all the configuration data inside the database.
There's a reasonable argument for restricting the names used for these
things in the SQL definitions to be valid SQL identifiers, so that that
will work nicely...

			regards, tom lane