To: Robert Haas <robertmhaas@gmail.com>
cc: Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>,
	Fujii Masao <masao.fujii@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	pgsql-docs@postgresql.org
Subject: Re: [HACKERS] Streaming replication document improvements 
In-reply-to: <j2t603c8f071004011018tbdcc5d17y1fe17b29ab08703c@mail.gmail.com> 
References: <3f0b79eb1003300152g5327eb47w8f9aecae6002b215@mail.gmail.com>
	<4BB3B2ED.5080606@enterprisedb.com>
	<u2w3f0b79eb1003311850m50193801tb49b04966f5544d0@mail.gmail.com>
	<t2m603c8f071003311852x3dd15512uc92e0865ba729548@mail.gmail.com>
	<g2z3f0b79eb1003311858y7f781c7u99e09e32c96aa79b@mail.gmail.com>
	<x2t603c8f071003311900v524ab37x44f9e52a2a69dc33@mail.gmail.com>
	<o2u3f0b79eb1003311914i6c9d896bic3d1b13152c6b0d8@mail.gmail.com>
	<4BB49B0C.1050901@enterprisedb.com>
	<j2t603c8f071004011018tbdcc5d17y1fe17b29ab08703c@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Thu, 01 Apr 2010 13:18:45 -0400"
Date: Thu, 01 Apr 2010 13:29:06 -0400
Message-ID: <19262.1270142946@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

Robert Haas <robertmhaas@gmail.com> writes:
> That seems pretty reasonable to me.  I haven't checked how much code
> impact there is.  I know Tom doesn't think we should change it at all,
> but surely pre-beta is the time to fix nasty corner cases that were
> added by recently committed patches?

What nasty corner case?  Having replication connections use superuser
reserved slots seems exactly the behavior I'd expect given that they are
running as superuser.  I agree it would be good to decouple that later,
but we already decided we are not going to try to separate replication
privilege from superuser in 9.0.

(Also, autovacuum workers are a quite separate concept since the DBA
doesn't set them up or deal with them directly.  So I'm unimpressed by
pointing to the treatment of autovacuum_max_workers as a precedent.)

			regards, tom lane