To: Magnus Hagander <magnus@hagander.net>
cc: Thom Brown <thom@linux.com>, pgsql-docs <pgsql-docs@postgresql.org>
Subject: Re: track_activity_query_size note 
In-reply-to: 
 <CABUevExX5i111ceG+9jmYwdbOd_Az3K6vw7wq+-4R6A=1XygeA@mail.gmail.com>
References: 
 <CAA-aLv7hDZvZifXca1G51uDX1viOMUMvANNN1zMHbHHp5szPbQ@mail.gmail.com>
	<CABUevEz1GTbCj_ctv2PBrMXMQc167TesaUQ34NanBZQY51eGaw@mail.gmail.com>
	<CAA-aLv56dd_iMt6MnCcZZJhWNZzxc2vAKyx6YmB5FORcKmM27A@mail.gmail.com>
	<CABUevEwwZLh2dqZcTcXXQU6ikDf+MYg=kZr3VtONxJY7-Oosrw@mail.gmail.com>
	<CAA-aLv7rKz7H=iaKKKv8-J6mJ7QC+K6zwgb9g+vR2wGaA4-2nQ@mail.gmail.com>
	<CABUevExX5i111ceG+9jmYwdbOd_Az3K6vw7wq+-4R6A=1XygeA@mail.gmail.com>
Comments: In-reply-to Magnus Hagander <magnus@hagander.net>
	message dated "Thu, 24 May 2012 15:03:56 +0200"
Date: Thu, 24 May 2012 10:19:10 -0400
Message-ID: <19344.1337869150@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

Magnus Hagander <magnus@hagander.net> writes:
> On Thu, May 24, 2012 at 2:59 PM, Thom Brown <thom@linux.com> wrote:
>>> I attach a proposed change to the docs which points out that if the
>>> size of track_activity_query_size is changed and the is server
>>> restarted, it won't have any effect if query statistics are already
>>> present.

> Ah, suddenly it makes sense.

> And in that case yes, the docs changes should go under
> pg_stat_statements, I believe.

But surely the statement is flat out wrong; or if it's not wrong,
there's a bug somewhere.  We do not absorb the value of
track_activity_query_size from the stats file.

			regards, tom lane