Subject: Re: [HACKERS] switching documentation build to XSLT
To: Tom Lane <tgl@sss.pgh.pa.us>,
 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
References: <2cdfe551-eb7b-b319-c96d-0d53cc0c2db8@2ndquadrant.com>
 <1aff5a5f-64aa-91c4-41c4-7952afe8a792@2ndquadrant.com>
 <31278.1479587695@sss.pgh.pa.us> <11056.1479840451@sss.pgh.pa.us>
Cc: pgsql-docs@postgresql.org
From: Alexander Law <exclusion@gmail.com>
Message-ID: <1b0574bd-2cfa-e950-f881-914e68b7c9ec@gmail.com>
Date: Wed, 23 Nov 2016 17:20:20 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <11056.1479840451@sss.pgh.pa.us>
Content-Type: multipart/mixed;
 boundary="------------716E03D2E902E570EFC66C21"
Precedence: bulk
Sender: pgsql-docs-owner@postgresql.org

This is a multi-part message in MIME format.
--------------716E03D2E902E570EFC66C21
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Hello,

The attached patch fixes this.

Best regards,
Alexander

22.11.2016 21:47, Tom Lane пишет:
> I wrote:
>> I notice that whereas <xref> used to generate text like
>> 	Section 4.1.2.7
>> now you get
>> 	Section 4.1.2.7, “Constants of Other Types”
> I also find that for some reason, the results are not formatted
> consistently.  Section cross-references are printed with quotes
> as shown above, but chapter cross-references have no quotes and
> instead the chapter title is italicized.  See for example the
> various cross-references for GiST about halfway down this page:
>
> https://www.postgresql.org/docs/devel/static/indexes-types.html
>
> TBH though, the more examples of this I look at, the less convinced
> I am that it's an improvement at all.  We have an awful lot of
> parenthetical cross-references like "(see Section 1.2.3)", which
> previously were easy to ignore while reading, but with long section
> titles attached to them they quite interrupt the sentence flow.
>
> I can kind of see the point when printing on dead trees, but in
> any format where the reference is a hyperlink, I think I'd vote
> for dropping the title and going back to the old output.
>
> 			regards, tom lane
>
>


--------------716E03D2E902E570EFC66C21
Content-Type: text/x-patch;
 name="xref-without-number-and-title.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="xref-without-number-and-title.patch"

diff --git a/doc/src/sgml/stylesheet-common.xsl b/doc/src/sgml/stylesheet-common.xsl
index c23d38f..9393848 100644
--- a/doc/src/sgml/stylesheet-common.xsl
+++ b/doc/src/sgml/stylesheet-common.xsl
@@ -37,6 +37,7 @@
 <xsl:param name="punct.honorific" select="''"></xsl:param>
 <xsl:param name="variablelist.term.break.after">1</xsl:param>
 <xsl:param name="variablelist.term.separator"></xsl:param>
+<xsl:param name="xref.with.number.and.title" select="0"></xsl:param>
 
 
 <!-- Change display of some elements -->

--------------716E03D2E902E570EFC66C21
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs

--------------716E03D2E902E570EFC66C21--