Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXHJ0-0007Ao-9C for pgsql-docs@arkaria.postgresql.org; Mon, 04 Oct 2021 06:18:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mXHIz-0002aP-71 for pgsql-docs@arkaria.postgresql.org; Mon, 04 Oct 2021 06:18:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mXHIy-0002Xf-Sn for pgsql-docs@lists.postgresql.org; Mon, 04 Oct 2021 06:18:29 +0000 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mXHIv-0004Fv-OO for pgsql-docs@lists.postgresql.org; Mon, 04 Oct 2021 06:18:27 +0000 Received: by mail-wr1-x42f.google.com with SMTP id t2so5216271wrb.8 for ; Sun, 03 Oct 2021 23:18:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec-at.20210112.gappssmtp.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=lHLQiAIqNjHTZwSoBVwFvglA0QQ2xOBYzTzKJlCgRts=; b=lQy5FN5UEL8zTBWCyIBxtjnkrUJIeaIyoMijq0LJM/n4LihOdNolP4afF9IXh8fv4E QmKR+lyRudCEhYlFFEZvIgJ33y1Zzd8px9CqkPRhaC9G7NaaklNwM03YDnlvWxys5P+3 spoeQ5ey9Y0D7dLtpfz0JcyS6Fg7x44q/F2qZeCWbEHIjV+Vm+D11pTEobqfLEIm7HdN QvizRrUKcC5+ob2kezevFEYGTeJGnufMwD+SyGOBKorKELovJU/Q7PG2TVvq2J7DAcbk Ltn7nBq9M3s8m8oh9MjaYHFpAFW0VB9A5+jxRTXPPVoCeOlofHxtM48ZtJK0ibQT9GBM O3ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=lHLQiAIqNjHTZwSoBVwFvglA0QQ2xOBYzTzKJlCgRts=; b=CPbcSEA5kzdAl8L7BzcJwFRzEv/Q0nrL+HkgaL0Q41NINx77++CVG4SgPWOfhlOtuG aRx7KtpRJ/J4ANAwruk5kD/5X49rLWGAzvuzmufBNYI/wHhyeXduVHUVgYZ6h4b1I2Ir wC/grmVTohKgNqsuMeG1X+eJxNox3KGQTdAUtZKS10nFeec/nSoj7zSVj1nqcktbZH0S dCpR+/DNG4CAjgUh1mVd7lycOsYrH/M50AYHVr1sYjfcJd9NSLnuhfH9QZvOFgXl5bzC 6Lm07zj0PKEnM7Ay1NArin0wOQIVHCFsSI7LIjf/hyPar3Dj8+bslNDrxIwLv7BY8877 K8OQ== X-Gm-Message-State: AOAM533tGmcr9TMxv2OE67jQPWqBZbUQYDvn+ZH5GTDoKu7fKGbgYF9Z WrlVf9U/IAyccC429QrOmQFkKg== X-Google-Smtp-Source: ABdhPJzMqx7XBXromzqFqB4jhuLBh284JAgID7Edo1yF1f87Ju4IJ5tlerUwaH77kNJv4OgBmHuDNw== X-Received: by 2002:a5d:464e:: with SMTP id j14mr8944414wrs.204.1633328303384; Sun, 03 Oct 2021 23:18:23 -0700 (PDT) Received: from localhost.localdomain (dynamic-e41ppu12g47187sxo-pd01.res.v6.highway.a1.net. [2001:871:5c:e7da:d95f:605c:c07:aa3c]) by smtp.gmail.com with ESMTPSA id o5sm13140943wrf.85.2021.10.03.23.18.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Oct 2021 23:18:23 -0700 (PDT) Message-ID: <1c0eefa304434f67fd6a5a9d3f420d59ac74623a.camel@cybertec.at> Subject: Re: small patch From: Laurenz Albe To: rir , pgsql-docs@lists.postgresql.org Date: Mon, 04 Oct 2021 08:18:22 +0200 In-Reply-To: <20211001163938.ifg4ayrsjwd7r6zr@localhost> References: <20211001163938.ifg4ayrsjwd7r6zr@localhost> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, 2021-10-01 at 21:06 -0400, rir wrote: > Minor changes to move.sgml and fetch.sgml. > > The text 'or empty' is inconsistent by restating what the > synopsis notation has expressed. > > The comments on sharing a language feature, while > likely helpful during review, seem verbose compared to > the non-commenting in other similar files. Thanks for the effort of preparing a patch. However, I don't think that is an improvement: - the comments pointing from MOVE to FETCH and vice versa are helpful for people who edit the documentation like you did - we should retain "empty or one of", otherwise the following syntax would be undocumented: FETCH FROM c; Yours, Laurenz Albe