Date: Thu, 22 Nov 2001 13:16:21 -0500
From: Brent Verner <brent@rcfile.org>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: pgsql-docs@postgresql.org
Subject: Re: sgml cleanup
Message-ID: <20011122131621.A35213@rcfile.org>
References: <20011121224721.A28646@rcfile.org>
	<Pine.LNX.4.30.0111221746421.766-100000@peter.localdomain>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="OXfL5xGRrasGEqWY"
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.30.0111221746421.766-100000@peter.localdomain>
User-Agent: Mutt/1.3.23i

--OXfL5xGRrasGEqWY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On 22 Nov 2001 at 18:21 (+0100), Peter Eisentraut wrote:
| Brent Verner writes:
| 
| >   In trying to get the doc/ tree in cvs to build, I noticed a _lot_ of
| > empty closing tags when I ran
| >
| >   sh$ nsgmls -s -wall ./book-decl.sgml ./reference.sgml
| 
| The -wall option isn't very useful.  Empty closing tags are perfectly
| legal.  I don't know if they're good style, but as long as you don't
| exaggerate I don't feel that they aren't.  They're not allowed in XML,
| though.

gotcha.  When I hit problems with the man.tar build, I started looking
for /any/ cause.  The '</>' was the first thing I noticed.

| >   Anyone care to share the details of the patched docbook2man-spec.pl
| > file mentioned in doc/src/Makefile.in?  Do these modifications fix the
| > problems seen above?
| 
| The man pages for release 7.1 where built with docbook2X 0.6.1 plus the
| patch available on my web page[1].  7.2 is probably going to be the same.
| 
| [1] http://webmail.postgresql.org/~petere/docbook2man.html

cool.  I ended up fixing up the newest (0.7.0) release of his script,
and finally did get man.tar built.  Is there any desire to distribute
a copy of the patched script in cvs?  This would make it much easier
for people who might want to package a given cvs snapshot...

I've attached a patch which adds a directory to search for docbook
stylesheets in the config/docbook.m4 if there is any interest in 
supporting another platform for building the cvs docs.  This (in 
addition to minor doc/src/Makefile mods[1]) allows me to build on
a debian (unstable) box.

[1] patch attached for this as well.

thanks.
  brent

-- 
"Develop your talent, man, and leave the world something. Records are 
really gifts from people. To think that an artist would love you enough
to share his music with anyone is a beautiful thing."  -- Duane Allman

--OXfL5xGRrasGEqWY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="pgsql-docbook.m4.diff"

Index: config/docbook.m4
===================================================================
RCS file: /projects/cvsroot/pgsql/config/docbook.m4,v
retrieving revision 1.1
diff -c -c -r1.1 docbook.m4
*** config/docbook.m4	2000/11/05 21:04:06	1.1
--- config/docbook.m4	2001/11/22 00:47:16
***************
*** 57,63 ****
        for pgac_postfix in \
          sgml/stylesheets/nwalsh-modular \
          sgml/stylesheets/docbook \
!         sgml/docbook/dsssl/modular
        do
          pgac_candidate=$pgac_prefix/$pgac_infix/$pgac_postfix
          if test -r "$pgac_candidate/html/docbook.dsl" \
--- 57,64 ----
        for pgac_postfix in \
          sgml/stylesheets/nwalsh-modular \
          sgml/stylesheets/docbook \
!         sgml/docbook/dsssl/modular \
!         sgml/docbook/stylesheet/dsssl/modular
        do
          pgac_candidate=$pgac_prefix/$pgac_infix/$pgac_postfix
          if test -r "$pgac_candidate/html/docbook.dsl" \

--OXfL5xGRrasGEqWY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="d.s.s.m.diff"

Index: doc/src/sgml/Makefile
===================================================================
RCS file: /projects/cvsroot/pgsql/doc/src/sgml/Makefile,v
retrieving revision 1.45
diff -c -c -r1.45 Makefile
*** doc/src/sgml/Makefile	2001/11/18 20:35:02	1.45
--- doc/src/sgml/Makefile	2001/11/22 18:15:16
***************
*** 40,45 ****
--- 40,49 ----
  EPSTOPDF = epstopdf
  
  
+ ifndef COLLATEINDEX
+ COLLATEINDEX = $(PERL) $(DOCBOOKSTYLE)/bin/collateindex.pl 
+ endif
+ 
  # docbook2man generates man pages from docbook refentry source code.
  
  ifndef D2MDIR
***************
*** 96,113 ****
  postgres.html: catalogs.gif connections.gif
  
  
! COLLATEINDEX = $(PERL) $(DOCBOOKSTYLE)/bin/collateindex.pl -f -g -t 'Index'
  
  ifeq (,$(wildcard HTML.index))
  bookindex.sgml:
! 	$(COLLATEINDEX) -o $@ -N
  setindex.sgml:
! 	$(COLLATEINDEX) -x -o $@ -N
  else
  bookindex.sgml: HTML.index
! 	$(COLLATEINDEX) -i 'bookindex' -o $@ $<
  setindex.sgml: HTML.index
! 	$(COLLATEINDEX) -i 'setindex' -x -o $@ $<
  endif
  
  
--- 100,117 ----
  postgres.html: catalogs.gif connections.gif
  
  
! COLLATEINDEXARGS = -f -g -t 'Index'
  
  ifeq (,$(wildcard HTML.index))
  bookindex.sgml:
! 	$(COLLATEINDEX) $(COLLATEINDEXARGS) -o $@ -N
  setindex.sgml:
! 	$(COLLATEINDEX) $(COLLATEINDEXARGS) -x -o $@ -N
  else
  bookindex.sgml: HTML.index
! 	$(COLLATEINDEX) $(COLLATEINDEXARGS) -i 'bookindex' -o $@ $<
  setindex.sgml: HTML.index
! 	$(COLLATEINDEX) $(COLLATEINDEXARGS) -i 'setindex' -x -o $@ $<
  endif
  
  

--OXfL5xGRrasGEqWY--