From: Bruce Momjian <pgman@candle.pha.pa.us>
Message-Id: <200403031903.i23J3Fx14760@candle.pha.pa.us>
Subject: Re: "ALSO" keyword to "CREATE RULE" patch
In-Reply-To: <Pine.LNX.4.58.0403010908500.28778@sablons.cri.ensmp.fr>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Date: Wed, 3 Mar 2004 14:03:15 -0500 (EST)
Cc: PostgreSQL Patches <pgsql-patches@postgresql.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII


Is ALSO part of the SQL standard?  I can't imagine it is because there
is no rule mention.  

I guess if were were coding from scratch, we could make the syntax
INSTEAD or ALSO, but at this point, I don't see adding ALSO as a useful
change.

---------------------------------------------------------------------------

Fabien COELHO wrote:
> 
> Dear patchers,
> 
> Please find attached a small patch to add an optionnal "ALSO" keyword
> to the "CREATE RULE" syntax.
> 
> The "ALSO" keyword can be used where "INSTEAD" would be used,
> to mean the opposite, i.e. the current default behavior of rules
> which adds operations to the current one. IMHO, it makes the
> intended behavior much clearer for the basic user (say, me;-).
> 
> CREATE RULE some_table_del AS
>   ON DELETE TO some_table DO ALSO
>   (
>     DELETE FROM this_other_table WHERE id=old.id;
>   );
> 
> Of course, the absence of the "ALSO" keyword preserves the previous
> behavior... that is it behaves the same as with the "ALSO" keyword.
> 
> This patch was made against 7.4.1 with the "difforig" script
> provided by postgresql.
> 
> It adds "ALSO" keyword in the parser code (two lines), fixes somehow the
> documentation and sql help, and modifies four of the "RULE"
> test cases to use this keyword instead of the default nothing-ness.
> 
> It validated for me with a "make check".
> 
> Have a nice day,
> 
> -- 
> Fabien Coelho - coelho@cri.ensmp.fr

Content-Description: 

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073