X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.2]) by svr1.postgresql.org (Postfix) with ESMTP id 78A7FD1C96B for ; Thu, 4 Mar 2004 14:53:00 +0000 (GMT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (neptune.hub.org [200.46.204.2]) (amavisd-new, port 10024) with ESMTP id 63573-07 for ; Thu, 4 Mar 2004 10:53:01 -0400 (AST) Received: from candle.pha.pa.us (candle.pha.pa.us [207.106.42.251]) by svr1.postgresql.org (Postfix) with ESMTP id B2FFBD1C968 for ; Thu, 4 Mar 2004 10:52:57 -0400 (AST) Received: (from pgman@localhost) by candle.pha.pa.us (8.11.6/8.11.6) id i24Equw00423; Thu, 4 Mar 2004 09:52:56 -0500 (EST) From: Bruce Momjian Message-Id: <200403041452.i24Equw00423@candle.pha.pa.us> Subject: Re: "ALSO" keyword to "CREATE RULE" patch In-Reply-To: <25495.1078411608@sss.pgh.pa.us> To: Tom Lane Date: Thu, 4 Mar 2004 09:52:56 -0500 (EST) Cc: Fabien COELHO , Jan Wieck , PostgreSQL Patches X-Mailer: ELM [version 2.4ME+ PL108 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by amavisd-new at postgresql.org X-Archive-Number: 200403/39 X-Sequence-Number: 9970 Tom Lane wrote: > Fabien COELHO writes: > > Most of the patch deals with the documentation, which is rather ugly > > because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there > > is no name for the default behavior. I think "ALSO" fixes this issue as it > > clarifies the explanations. > > Hmm ... I find that argument much more convincing than any of the others > ... > > Jan, what do you think? You invented this command's syntax IIRC. I thought the syntax came from Berkeley. We can add ALSO if folks like it. I can't think of cases where we have keywords for both on and off behavior, and allow a default if the keyword is missing. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073