X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.2]) by svr1.postgresql.org (Postfix) with ESMTP id 2CEB3D1CAD0 for ; Thu, 4 Mar 2004 15:36:33 +0000 (GMT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (neptune.hub.org [200.46.204.2]) (amavisd-new, port 10024) with ESMTP id 16572-04 for ; Thu, 4 Mar 2004 11:36:32 -0400 (AST) Received: from candle.pha.pa.us (candle.pha.pa.us [207.106.42.251]) by svr1.postgresql.org (Postfix) with ESMTP id D8E60D1CA50 for ; Thu, 4 Mar 2004 11:36:28 -0400 (AST) Received: (from pgman@localhost) by candle.pha.pa.us (8.11.6/8.11.6) id i24FaMG06712; Thu, 4 Mar 2004 10:36:22 -0500 (EST) From: Bruce Momjian Message-Id: <200403041536.i24FaMG06712@candle.pha.pa.us> Subject: Re: "ALSO" keyword to "CREATE RULE" patch In-Reply-To: To: Fabien COELHO Date: Thu, 4 Mar 2004 10:36:22 -0500 (EST) Cc: Tom Lane , Jan Wieck , PostgreSQL Patches X-Mailer: ELM [version 2.4ME+ PL108 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by amavisd-new at postgresql.org X-Archive-Number: 200403/41 X-Sequence-Number: 9972 Fabien COELHO wrote: > > > I thought the syntax came from Berkeley. We can add ALSO if folks like > > it. I can't think of cases where we have keywords for both on and off > > behavior, and allow a default if the keyword is missing. > > ALTER TABLE ... DROP CONSTRAINT ... [ RESTRICT | CASCADE ] ; > > CREATE TABLE ... [ WITH OIDS | WITHOUT OIDS ] ... ; > > CREATE USER ... [ CREATEDB | NOCREATEDB ] ... ; > > IMHO, from the language design point of view, it seems better if all > options have a name. Makes sense to me now. No one liked the non-INSTEAD rule description, for sure. Shoot me the patch again and I will put in the the queue. Thanks. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073