X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.2]) by svr1.postgresql.org (Postfix) with ESMTP id EA303D1BA53 for ; Thu, 4 Mar 2004 23:32:15 +0000 (GMT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (neptune.hub.org [200.46.204.2]) (amavisd-new, port 10024) with ESMTP id 93099-01 for ; Thu, 4 Mar 2004 19:32:15 -0400 (AST) Received: from candle.pha.pa.us (candle.pha.pa.us [207.106.42.251]) by svr1.postgresql.org (Postfix) with ESMTP id 80E54D1B4E4 for ; Thu, 4 Mar 2004 19:32:10 -0400 (AST) Received: (from pgman@localhost) by candle.pha.pa.us (8.11.6/8.11.6) id i24NVs913028; Thu, 4 Mar 2004 18:31:54 -0500 (EST) From: Bruce Momjian Message-Id: <200403042331.i24NVs913028@candle.pha.pa.us> Subject: Re: "ALSO" keyword to "CREATE RULE" patch In-Reply-To: <4047BA9B.3010302@Yahoo.com> To: Jan Wieck Date: Thu, 4 Mar 2004 18:31:54 -0500 (EST) Cc: Tom Lane , Fabien COELHO , PostgreSQL Patches X-Mailer: ELM [version 2.4ME+ PL108 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by amavisd-new at postgresql.org X-Archive-Number: 200403/50 X-Sequence-Number: 9981 Jan Wieck wrote: > Tom Lane wrote: > > > Fabien COELHO writes: > >> Most of the patch deals with the documentation, which is rather ugly > >> because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there > >> is no name for the default behavior. I think "ALSO" fixes this issue as it > >> clarifies the explanations. > > > > Hmm ... I find that argument much more convincing than any of the others > > ... > > > > Jan, what do you think? You invented this command's syntax IIRC. > > I did not. We inherited it from Postgres 4.2. If people think an ALSO > keyword will clearify things, what about renaming the whole CREATE RULE > into something along the line CREATE QUERY REWRITE MACRO? Are you saying you don't want ALSO added? -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073