X-Original-To: pgsql-www-postgresql.org@localhost.postgresql.org Received: from localhost (unknown [200.46.204.144]) by svr1.postgresql.org (Postfix) with ESMTP id 0AC693A4941; Thu, 20 Jan 2005 21:51:25 +0000 (GMT) Received: from svr1.postgresql.org ([200.46.204.71]) by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024) with ESMTP id 83607-09; Thu, 20 Jan 2005 21:51:19 +0000 (GMT) Received: from sunsite.dcc.uchile.cl (sunsite.dcc.uchile.cl [192.80.24.2]) by svr1.postgresql.org (Postfix) with ESMTP id 55B7A3A4905; Thu, 20 Jan 2005 21:51:20 +0000 (GMT) Received: from anakena.dcc.uchile.cl ([192.80.24.3]) by sunsite.dcc.uchile.cl (8.12.11/8.12.11) with ESMTP id j0KLpHK5029735; Thu, 20 Jan 2005 18:51:17 -0300 (CLST) Received: by anakena.dcc.uchile.cl (Postfix, from userid 4151) id E818C524CB; Thu, 20 Jan 2005 18:51:16 -0300 (CLST) Date: Thu, 20 Jan 2005 18:51:16 -0300 From: Alvaro Herrera To: Tom Lane Cc: Magnus Hagander , Mike Blackwell , pgsql-docs@postgresql.org, pgsql-www@postgresql.org Subject: Re: [DOCS] [BUGS] BUG #1414: DOC - pl/Perl hash tags missing Message-ID: <20050120215116.GA3135@dcc.uchile.cl> References: <6BCB9D8A16AC4241919521715F4D8BCE476696@algol.sollentuna.se> <9277.1106256196@sss.pgh.pa.us> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9277.1106256196@sss.pgh.pa.us> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at hub.org X-Spam-Status: No, hits=0.338 tagged_above=0 required=5 tests=AWL, DNS_FROM_RFC_ABUSE X-Spam-Level: X-Archive-Number: 200501/585 X-Sequence-Number: 7328 On Thu, Jan 20, 2005 at 04:23:16PM -0500, Tom Lane wrote: > "Magnus Hagander" writes: > > Going out on a line a bit here - and someone who've worked with teh > > system probably knows for sure but... It looks like {} is used as the > > template placeholder in the templating system on the website. > > > It would seem to me that the fix would be as simple as to set > > $removeUnknownVariables to false when parsing the docs template, but I'm > > far from sure at that. And I have no way to test it. And it might break > > something else. End of disclaimers. > > If the docs template is applying any substitution whatsoever to the > documentation HTML files, it's broken. I don't think the above fix > is appropriate --- what if the docs contain {foo} where foo does match > some variable known to the substituter? Probably the solution is to use some sort of template escaping, like {literal} in PHP's smarty. Not sure what the site is using. -- Alvaro Herrera () Al principio era UNIX, y UNIX habló y dijo: "Hello world\n". No dijo "Hello New Jersey\n", ni "Hello USA\n".