From: Bruce Momjian <pgman@candle.pha.pa.us>
Message-Id: <200509170431.j8H4VGP19475@candle.pha.pa.us>
Subject: Re: [HACKERS] statement_timeout logging
In-Reply-To: <KGEFLMPJFBNNLNOOOPLGKEFICJAA.simon@2ndquadrant.com>
To: Simon Riggs <simon@2ndquadrant.com>
Date: Sat, 17 Sep 2005 00:31:16 -0400 (EDT)
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	PostgreSQL-documentation <pgsql-docs@postgresql.org>,
	pgsql-hackers@postgresql.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII

Simon Riggs wrote:
> >Alvaro Herrera
> > On Fri, Sep 16, 2005 at 03:41:11PM -0400, Bruce Momjian wrote:
> > > > I have updated the message to:
> > > >
> > > >      errmsg("canceling query due to user request or
> > statement timeout")));
> > >
> > > Oops.  Did we freeze the message strings already for this release?
> >
> > Not yet.
> >
> > I'm not sure I agree with the wording though -- is there no
> > way to tell
> > the difference?
> 
> Yes, my patch. :-)
> 
> The message is generated following receipt of a SIGINT which is sent by
> kill() after the statement_timeout.
> 
> My patch was able to generate a different message by logging just before
> the kill() is called. (Obviously, there isn't much "after" in this
> circumstance).

Your patch just prints a statement "before" printing the cancel message.
What we should do is to print the proper cause of the cancel, and I am
working on a patch for that.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073