X-Original-To: pgsql-patches-postgresql.org@localhost.postgresql.org
Received: from localhost (mx1.hub.org [200.46.208.251])
	by postgresql.org (Postfix) with ESMTP id A87D89F9CEE
	for <pgsql-patches-postgresql.org@localhost.postgresql.org>;
	Thu, 18 May 2006 00:20:55 -0300 (ADT)
Received: from postgresql.org ([200.46.204.71])
	by localhost (mx1.hub.org [200.46.208.251]) (amavisd-new, port 10024)
	with ESMTP id 74542-09
	for <pgsql-patches-postgresql.org@localhost.postgresql.org>;
	Thu, 18 May 2006 00:20:46 -0300 (ADT)
X-Greylist: from auto-whitelisted by SQLgrey-
Received: from candle.pha.pa.us (candle.pha.pa.us [70.90.9.53])
	by postgresql.org (Postfix) with ESMTP id 88BDB9FA294
	for <pgsql-patches@postgresql.org>;
	Thu, 18 May 2006 00:20:46 -0300 (ADT)
Received: (from pgman@localhost)
	by candle.pha.pa.us (8.11.6/8.11.6) id k4I3Kdb29964;
	Wed, 17 May 2006 23:20:39 -0400 (EDT)
From: Bruce Momjian <pgman@candle.pha.pa.us>
Message-Id: <200605180320.k4I3Kdb29964@candle.pha.pa.us>
Subject: Re: small doc patch for regexp_replace
In-Reply-To: <7317.1147921141@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 17 May 2006 23:20:39 -0400 (EDT)
CC: Joachim Wieland <joe@mcknight.de>, pgsql-patches@postgresql.org
X-Mailer: ELM [version 2.4ME+ PL121 (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Archive-Number: 200605/209
X-Sequence-Number: 19755

Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > Seems there is some inconsistency there.  There are two types of
> > function listings, one with just the types, and another with param_name
> > and then type.  We use "string" instead of "text" because varchar() and
> > char() can also be used.
> 
> Where did that come from?  The actual functions generally take "text",
> relying on implicit conversions to handle the other types.  Since we do
> not have any type named "string", I think the locution <type>string</>
> is a contradiction in terms.
> 
> IMHO these should all go back to <type>text</>.

Well, we actually have <parameter>string</> and I got a few wrong.  I
have committed the changes.	If we want to use <type>text</> instead
of <parameter>string</>, I can make that change too.  There are quite a
few of them, like md5().  Yes?

-- 
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +