X-Original-To: pgsql-hackers-postgresql.org@postgresql.org Received: from localhost (wm.hub.org [200.46.204.128]) by postgresql.org (Postfix) with ESMTP id A599D9FC179 for ; Sat, 26 Aug 2006 13:47:38 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.128]) (amavisd-new, port 10024) with ESMTP id 79409-01 for ; Sat, 26 Aug 2006 16:47:30 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey- Received: from momjian.us (momjian.us [70.90.9.53]) by postgresql.org (Postfix) with ESMTP id DB6579FC176 for ; Sat, 26 Aug 2006 13:47:29 -0300 (ADT) Received: (from bruce@localhost) by momjian.us (8.11.6/8.11.6) id k7QGlMF04492; Sat, 26 Aug 2006 12:47:22 -0400 (EDT) From: Bruce Momjian Message-Id: <200608261647.k7QGlMF04492@momjian.us> Subject: Re: New XML section for documentation In-Reply-To: To: nikolay@samokhvalov.com Date: Sat, 26 Aug 2006 12:47:22 -0400 (EDT) CC: Peter Eisentraut , PostgreSQL-development X-Mailer: ELM [version 2.4ME+ PL123] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="US-ASCII" X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200608/1731 X-Sequence-Number: 89224 Nikolay Samokhvalov wrote: > On 8/26/06, Peter Eisentraut wrote: > > Bruce Momjian wrote: > > > Validation > > > ---------- > > > /contrib/xml2 has a function called xml_valid() that can be used in > > > a CHECK constraint to enforce that a field contains valid XML. It > > > does not support validation against a specific XML schema. > > > > Then this is not validation but only checking for well-formedness. The > > xml2 README says so, in fact. > > Exactly. contrib/xml2 mixes the term here, xml_valid() should be > another function, that takes two types of data - XML value and > corresponding XML schema - and validate the XML data. Actually, the > latest version of SQL/XML standard includes such a function > (XMLVALIDATE). I understand, but do we want to break backward compatibility to rename it? We could create a xml_check, and keep xml_valid as a single-argument function, and implement schema-checks as a two-parameter function, but that seems odd too. > If you decide to include the mentioning about contrib/xml2 to docs, I > would suggest the patch for this module. The patch renames that > function to xml_check() and adds xml_array() (issue from the current > TODO). Or it's too late for 8.2? Hard to say. What does xml_array do? We are more lenient about /contrib additions after feature freeze, but it is pretty late. Aren't you working on updating the new XML syntax support in the backend? Are you done with that patch? > Also, I would add a little introduction to XML terms (from XML > standards) to this documentation section. OK, but which terms. I only see XML and XSLT, and I documented those on first mention in the newest version. -- Bruce Momjian bruce@momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +