From: Bruce Momjian <bruce@momjian.us>
Message-Id: <200701272033.l0RKXox24521@momjian.us>
Subject: Re: Change draft gmake control
In-Reply-To: <200701271728.04355.peter_e@gmx.net>
To: Peter Eisentraut <peter_e@gmx.net>
Date: Sat, 27 Jan 2007 15:33:50 -0500 (EST)
CC: pgsql-docs@postgresql.org,
	PostgreSQL-patches <pgsql-patches@postgresql.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > Nothing, but the point is that draft is a modifier and it isn't clear
> >
> > >from that syntax that draft is a modifier and not a target.
> > >
> > > Anyway, certainly you could write this to preserve the target:
> > >
> > > draft:
> > > 	$(MAKE) html DRAFT=Y
> >
> > The problem is that the 'gmake' recursion is done, but then returns
> > and runs the hhml again, so 'gmake draft html' calls "$(MAKE) html
> > DRAFT=Y" and on return from that, the html is called again and
> > rebuilds, so it isn't really draft.
> 
> Well, "gmake draft html" doesn't make any sense anyway, but "gmake 
> draft" by itself does and the new way of writing it is significantly 
> more cumbersome, so I request that this be fixed.

Well, if 'draft' was only for html, I could see suggesting just 'gmake
draft', but 'draft' can be used for Postscript and PDF too.
 
-- 
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +