Received: from localhost (maia-3.hub.org [200.46.204.184])
	by postgresql.org (Postfix) with ESMTP id 4D24F9FB59E;
	Sat,  7 Apr 2007 00:49:19 -0300 (ADT)
Received: from postgresql.org ([200.46.204.71])
	by localhost (mx1.hub.org [200.46.204.184]) (amavisd-maia, port 10024)
	with ESMTP id 16212-02; Sat,  7 Apr 2007 00:49:11 -0300 (ADT)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.4
X-Greylist: from auto-whitelisted by SQLgrey-1.7.4
Received: from momjian.us (momjian.us [70.90.9.53])
	by postgresql.org (Postfix) with ESMTP id 30E0D9FB484;
	Sat,  7 Apr 2007 00:49:08 -0300 (ADT)
Received: (from bruce@localhost) by momjian.us (8.11.6/8.11.6) id
 l373n4l13436;
	Fri, 6 Apr 2007 23:49:04 -0400 (EDT)
From: Bruce Momjian <bruce@momjian.us>
Message-Id: <200704070349.l373n4l13436@momjian.us>
Subject: Re: [PATCHES] Fix misleading references to columns in
	GRANT/REVOKE summaries
In-Reply-To: <847.1175912697@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Date: Fri, 6 Apr 2007 23:49:04 -0400 (EDT)
CC: Russell Smith <mr-russ@pws.com.au>, David Fetter <david@fetter.org>,
	PostgreSQL Docs <pgsql-docs@postgresql.org>,
	PostgreSQL Patches <pgsql-patches@postgresql.org>
X-Mailer: ELM [version 2.4ME+ PL123]
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="ELM1175917744-26605-0_"
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Archive-Number: 200704/5
X-Sequence-Number: 4201


--ELM1175917744-26605-0_
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

Tom Lane wrote:
> Russell Smith <mr-russ@pws.com.au> writes:
> > Tom Lane wrote:
> >> The entire *point* of that paragraph is that we don't have the
> >> feature.  This proposed change is surely not an improvement...
> >> 
> > Maybe removing the entire example would be more helpful.  I don't find 
> > it clear to have a command outline in a compatibility block.
> 
> True, there doesn't seem to be any point in providing a full syntax
> summary rather than just saying "the SQL spec says you can grant
> privileges on columns but we don't support that yet".

Agreed.  Patch attached and applied.  I don't see any other cases of
this in our documentation.

-- 
  Bruce Momjian  <bruce@momjian.us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

--ELM1175917744-26605-0_
Content-Transfer-Encoding: 7bit
Content-Type: text/x-diff
Content-Disposition: inline; filename="/rtmp/diff"

Index: doc/src/sgml/ref/grant.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/ref/grant.sgml,v
retrieving revision 1.64
diff -c -c -r1.64 grant.sgml
*** doc/src/sgml/ref/grant.sgml	1 Feb 2007 00:28:19 -0000	1.64
--- doc/src/sgml/ref/grant.sgml	7 Apr 2007 03:45:36 -0000
***************
*** 520,533 ****
     </para>
  
     <para>
!     The SQL standard allows setting privileges for individual columns
!     within a table:
! 
! <synopsis>
! GRANT <replaceable class="PARAMETER">privileges</replaceable>
!     ON <replaceable class="PARAMETER">table</replaceable> [ ( <replaceable class="PARAMETER">column</replaceable> [, ...] ) ] [, ...]
!     TO { PUBLIC | <replaceable class="PARAMETER">username</replaceable> [, ...] } [ WITH GRANT OPTION ]
! </synopsis>
     </para>
  
     <para>
--- 520,527 ----
     </para>
  
     <para>
!     <productname>PostgreSQL</productname> does not support the SQL-standard 
!     functionality of setting privileges for individual columns.
     </para>
  
     <para>
Index: doc/src/sgml/ref/revoke.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/ref/revoke.sgml,v
retrieving revision 1.42
diff -c -c -r1.42 revoke.sgml
*** doc/src/sgml/ref/revoke.sgml	31 Jan 2007 23:26:04 -0000	1.42
--- doc/src/sgml/ref/revoke.sgml	7 Apr 2007 03:45:37 -0000
***************
*** 231,245 ****
  
     <para>
      The compatibility notes of the <xref linkend="sql-grant" endterm="sql-grant-title"> command
!     apply analogously to <command>REVOKE</command>.  The syntax summary is:
! 
! <synopsis>
! REVOKE [ GRANT OPTION FOR ] <replaceable class="PARAMETER">privileges</replaceable>
!     ON <replaceable class="parameter">object</replaceable> [ ( <replaceable class="parameter">column</replaceable> [, ...] ) ]
!     FROM { PUBLIC | <replaceable class="parameter">username</replaceable> [, ...] }
!     { RESTRICT | CASCADE }
! </synopsis>
!     One of <literal>RESTRICT</literal> or <literal>CASCADE</literal>
      is required according to the standard, but <productname>PostgreSQL</>
      assumes <literal>RESTRICT</literal> by default.
     </para>
--- 231,238 ----
  
     <para>
      The compatibility notes of the <xref linkend="sql-grant" endterm="sql-grant-title"> command
!     apply analogously to <command>REVOKE</command>.
!     <literal>RESTRICT</literal> or <literal>CASCADE</literal>
      is required according to the standard, but <productname>PostgreSQL</>
      assumes <literal>RESTRICT</literal> by default.
     </para>

--ELM1175917744-26605-0_--