Date: Thu, 17 May 2007 11:53:19 -0400
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <heikki@enterprisedb.com>,
	Chris Browne <cbbrowne@acm.org>, pgsql-patches@postgresql.org
Subject: Re: [DOCS] Autovacuum and XID wraparound
Message-ID: <20070517155319.GF28701@alvh.no-ip.org>
References: <464B0E5A.1070807@enterprisedb.com>
 <6549.1179344646@sss.pgh.pa.us>
	<464B60A7.3070106@enterprisedb.com> <7145.1179347418@sss.pgh.pa.us>
	<464B6B08.6030609@enterprisedb.com> <7460.1179349272@sss.pgh.pa.us>
	<20070516210531.GL4582@alvh.no-ip.org>
	<7667.1179350456@sss.pgh.pa.us>
	<20070516224627.GP4582@alvh.no-ip.org>
	<9823.1179360041@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9823.1179360041@sss.pgh.pa.us>
User-Agent: Mutt/1.5.13 (2006-08-11)

Tom Lane wrote:
> Alvaro Herrera <alvherre@commandprompt.com> writes:
> > Here is my proposed patch.
> 
> Actually, the original patch in this series was fairly horrid, and
> things haven't been made better by the subsequent changes.  It lacked
> any comment explaining what it was doing; failed to comment on the way
> it was abusing heap_freeze_tuple (the latter thinks it's getting a tuple
> that's in a disk buffer); and IMHO puts the heap_freeze_tuple call in
> the wrong place anyway.  raw_heap_insert has no business editorializing
> on the tuple it's given.  It'd be better to have the call in
> rewrite_heap_tuple, which is already busy messing with the tuple's
> visibility info.  Perhaps like this, in addition to your changes:

Applied, thanks.  Let me know if there is still something you don't like
about the current state of cluster or truncate.

The part about actually advancing relfrozenxid is still not done though ...

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support