Date: Mon, 3 Sep 2007 09:56:09 +0200
From: Magnus Hagander <magnus@hagander.net>
To: Gregory Stark <stark@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Oleg Bartunov <oleg@sai.msu.su>,
	Pavel Stehule <pavel.stehule@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: tsearch filenames unlikes special symbols and numbers
Message-ID: <20070903075609.GD21833@svr2.hagander.net>
References: <162867790709021328i7771aa9jfe79268bccbf123d@mail.gmail.com>
	<Pine.LNX.4.64.0709030113090.2767@sn.sai.msu.ru>
	<18259.1188773171@sss.pgh.pa.us>
	<87y7foir7t.fsf@oxford.xeocode.com>
	<19257.1188777110@sss.pgh.pa.us>
	<87tzqci6tp.fsf@oxford.xeocode.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87tzqci6tp.fsf@oxford.xeocode.com>
User-Agent: Mutt/1.5.11

On Mon, Sep 03, 2007 at 07:47:14AM +0100, Gregory Stark wrote:
> "Tom Lane" <tgl@sss.pgh.pa.us> writes:
> 
> > Gregory Stark <stark@enterprisedb.com> writes:
> >> "Tom Lane" <tgl@sss.pgh.pa.us> writes:
> >>> I made it reject all but latin letters, which is the same restriction
> >>> that's in place for timezone set filenames.  That might be overly
> >>> strong, but we definitely have to forbid "." and "/" (and "\" on
> >>> Windows).  Do we want to restrict it to letters, digits, underscore?
> >>> Or does it need to be weaker than that?
> >
> >> What's the problem with "."?
> >
> > ../../../../etc/passwd
> >
> > Possibly we could allow '.' as long as we forbade /, 
> 
> Right, traditionally the only characters forbidden in filenames in Unix are /
> and nul. If we want the files to play nice in Gnome etc then we should
> restrict them to ascii since we don't know what encoding the gui expects. 
> 
> Actually I think in Windows \ : and . are problems (not allowed more than one
> dot in dos).

\ and : are problems.

. is not a problem. We don't support 16-bit windows anyway, and multiple
dots works fine on any system we support.

//Magnus