Received: from localhost (unknown [200.46.204.182])
	by postgresql.org (Postfix) with ESMTP id 060002E0071
	for <pgsql-docs-postgresql.org@postgresql.org>;
	Wed, 28 Nov 2007 16:57:35 -0400 (AST)
Received: from postgresql.org ([200.46.204.71])
	by localhost (mx1.hub.org [200.46.204.182]) (amavisd-maia, port 10024)
	with ESMTP id 92136-07 for <pgsql-docs-postgresql.org@postgresql.org>;
	Wed, 28 Nov 2007 16:57:28 -0400 (AST)
Received: from momjian.us (momjian.us [70.90.9.53])
	by postgresql.org (Postfix) with ESMTP id 590D12E00D2
	for <pgsql-docs@postgresql.org>; Wed, 28 Nov 2007 16:57:30 -0400 (AST)
Received: (from bruce@localhost) by momjian.us (8.11.6/8.11.6) id
 lASKvSt19769;
	Wed, 28 Nov 2007 15:57:28 -0500 (EST)
From: Bruce Momjian <bruce@momjian.us>
Message-Id: <200711282057.lASKvSt19769@momjian.us>
Subject: Re: Two fixes for plpgsql.sgml
In-Reply-To: <20923.1196282281@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 28 Nov 2007 15:57:28 -0500 (EST)
CC: Guillaume Lelarge <guillaume@lelarge.info>,
	Neil Conway <neilc@samurai.com>, pgsql-docs@postgresql.org
X-Mailer: ELM [version 2.4ME+ PL124 (25)]
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="ELM1196283448-12213-4_"
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Archive-Number: 200711/110
X-Sequence-Number: 4643


--ELM1196283448-12213-4_
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > Agreed. I couldn't find any value to that phrase and couldn't find better
> > wording, so I removed it.  Patch attached and applied.
> 
> This is not an improvement.
> 
> The point of the original wording is that you have to say
> 	RETURNS SETOF sometype
> you can't just say, eg,
> 	RETURNS SET
> 
> Your new wording would lead the reader to the assumption that he can
> just declare a function as returning "set".
> 
> Please revert the change.

I found the original confusing, as did the author, so I updated the docs
again.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

--ELM1196283448-12213-4_
Content-Transfer-Encoding: 7bit
Content-Type: text/x-diff
Content-Disposition: inline; filename="/rtmp/diff"

Index: plpgsql.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/plpgsql.sgml,v
retrieving revision 1.119
diff -c -r1.119 plpgsql.sgml
*** plpgsql.sgml	28 Nov 2007 20:13:06 -0000	1.119
--- plpgsql.sgml	28 Nov 2007 20:56:17 -0000
***************
*** 132,141 ****
      </para>
  
      <para>
!      <application>PL/pgSQL</> functions can also be declared to return
!      a <quote>set</>, or table.  Such a function generates its output by
!      executing <command>RETURN NEXT</> for each desired element of the result
!      set, or by using <command>RETURN QUERY</> to output the result of
       evaluating a query.
      </para>
  
--- 132,142 ----
      </para>
  
      <para>
!      <application>PL/pgSQL</> functions can also be declared to return a
!      group of values, either as a single row, or a group of rows, like a
!      table.  Such a function generates its output by executing
!      <command>RETURN NEXT</> for each desired element of the result set,
!      or by using <command>RETURN QUERY</> to output the result of
       evaluating a query.
      </para>
  

--ELM1196283448-12213-4_--