Received: from localhost (unknown [200.46.204.183])
	by postgresql.org (Postfix) with ESMTP id 772482E2F1C;
	Thu,  6 Mar 2008 12:32:16 -0400 (AST)
Received: from postgresql.org ([200.46.204.71])
	by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024)
	with ESMTP id 68674-01; Thu,  6 Mar 2008 12:32:13 -0400 (AST)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.5
X-Greylist: from auto-whitelisted by SQLgrey-1.7.5
Received: from momjian.us (momjian.us [70.90.9.53])
	by postgresql.org (Postfix) with ESMTP id D772E2E2F15;
	Thu,  6 Mar 2008 12:32:12 -0400 (AST)
Received: (from bruce@localhost) by momjian.us (8.11.6/8.11.6) id
 m26GW3L04395;
	Thu, 6 Mar 2008 11:32:03 -0500 (EST)
From: Bruce Momjian <bruce@momjian.us>
Message-Id: <200803061632.m26GW3L04395@momjian.us>
Subject: Re: [HACKERS] bgwriter_lru_multiplier blurbs
 inconsistent
In-Reply-To: <19882.1200886188@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Date: Thu, 6 Mar 2008 11:32:03 -0500 (EST)
CC: Greg Smith <gsmith@gregsmith.com>,
	Alvaro Herrera <alvherre@commandprompt.com>, pgsql-docs@postgresql.org,
	Hackers <pgsql-hackers@postgresql.org>
X-Mailer: ELM [version 2.4ME+ PL124 (25)]
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="ELM1204821123-8024-1_"
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Archive-Number: 200803/33
X-Sequence-Number: 4845


--ELM1204821123-8024-1_
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

Tom Lane wrote:
> Greg Smith <gsmith@gregsmith.com> writes:
> > On Sun, 20 Jan 2008, Tom Lane wrote:
> >> I think the main problem is the qualifying clause up front in a place
> >> of prominence.  Here's a V3 try
> 
> > That one looks good to me.  These are small details but better to get it 
> > right now.
> 
> OK, committed.  Back to Alvaro's original concern: is the short
> description in guc.c all right, or can we improve that?

I have tried to improve the GUC description for
"bgwriter_lru_multiplier";  applied to CVS HEAD.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

--ELM1204821123-8024-1_
Content-Transfer-Encoding: 7bit
Content-Type: text/x-diff
Content-Disposition: inline; filename="/rtmp/diff"

Index: src/backend/utils/misc/guc.c
===================================================================
RCS file: /cvsroot/pgsql/src/backend/utils/misc/guc.c,v
retrieving revision 1.432
diff -c -c -r1.432 guc.c
*** src/backend/utils/misc/guc.c	30 Jan 2008 18:35:55 -0000	1.432
--- src/backend/utils/misc/guc.c	6 Mar 2008 16:22:44 -0000
***************
*** 1841,1847 ****
  
  	{
  		{"bgwriter_lru_multiplier", PGC_SIGHUP, RESOURCES,
! 			gettext_noop("Background writer multiplier on average buffers to scan per round."),
  			NULL
  		},
  		&bgwriter_lru_multiplier,
--- 1841,1847 ----
  
  	{
  		{"bgwriter_lru_multiplier", PGC_SIGHUP, RESOURCES,
! 			gettext_noop("Multiple of the average buffer usage to free per round."),
  			NULL
  		},
  		&bgwriter_lru_multiplier,

--ELM1204821123-8024-1_--