From: Bruce Momjian <bruce@momjian.us>
Message-Id: <200809071231.m87CVmD12043@momjian.us>
Subject: Re: Incorrect description of xmax and xip in functions
 docs
In-Reply-To: <1220786063.3913.8.camel@ebony.2ndQuadrant>
To: Simon Riggs <simon@2ndQuadrant.com>
Date: Sun, 7 Sep 2008 08:31:48 -0400 (EDT)
CC: pgsql-docs <pgsql-docs@postgresql.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

Simon Riggs wrote:
> 
> On Sat, 2008-09-06 at 21:31 -0400, Bruce Momjian wrote:
> > Applied, and attached.
> 
> Thanks.
> 
> > > And for txid_visible_in_snapshot() comment added:
> > > "Function should not be used with subtransaction xids. It is possible
> > > that this function will return a true result for a subtransaction xid
> > > that was actually still in progress at the time of the snapshot".
> > 
> > I think the cleaner solution is to throw an appropriate error if a
> > subtransaction xid is used, rather than adding documentation.
> 
> Or maybe check subtrans for it, as it really should be doing.

Yea, that's what I meant.  You can't be sure everyone is going to read
the documentation but they are sure to see the function results or error
message.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +