Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id A30A2633A6C for ; Mon, 6 Apr 2009 18:01:53 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 59979-09 for ; Mon, 6 Apr 2009 18:01:47 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from momjian.us (momjian.us [70.90.9.53]) by mail.postgresql.org (Postfix) with ESMTP id EBD8D63344F for ; Mon, 6 Apr 2009 18:01:51 -0300 (ADT) Received: (from bruce@localhost) by momjian.us (8.11.6/8.11.6) id n36L1lK01030; Mon, 6 Apr 2009 17:01:47 -0400 (EDT) From: Bruce Momjian Message-Id: <200904062101.n36L1lK01030@momjian.us> Subject: Re: log_min_duration_statement units In-Reply-To: <49DA5E05.4090904@timbira.com> To: Euler Taveira de Oliveira Date: Mon, 6 Apr 2009 17:01:47 -0400 (EDT) CC: PostgreSQL-documentation X-Mailer: ELM [version 2.4ME+ PL124 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="US-ASCII" X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.057 tagged_above=0 required=5 tests=AWL=0.057 X-Spam-Level: X-Archive-Number: 200904/13 X-Sequence-Number: 5101 Euler Taveira de Oliveira wrote: > Bruce Momjian escreveu: > > Someone complained that the default units for log_min_duration_statement > > was not mentioned in postgresql.conf; this applied patch fixes that. > > > IMHO -1ms doesn't make much sense. Also, some other parameters don't have > units too. They are: archive_timeout, autovacuum_vacuum_cost_delay, > log_autovacuum_min_duration, log_temp_files, statement_timeout, > tcp_keepalives_idle, and tcp_keepalives_interval. What about mention the unit > in the comment that follows it? The last two already have it. Thanks for the list! Here is an applied patch that cleans these up, plus fixes log_min_duration_statement. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. +