Received: from localhost (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 444146349F8 for ; Tue, 7 Apr 2009 19:30:12 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 37429-08 for ; Tue, 7 Apr 2009 19:30:08 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from lists.commandprompt.com (host-159.commandprompt.net [207.173.203.159]) by mail.postgresql.org (Postfix) with ESMTP id AE5F8634288 for ; Tue, 7 Apr 2009 19:30:08 -0300 (ADT) Received: from perhan.alvh.no-ip.org (200-126-99-132.bk7-dsl.surnet.cl [200.126.99.132]) (authenticated bits=0) by lists.commandprompt.com (8.13.8/8.13.8) with ESMTP id n37Mamed026752 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 7 Apr 2009 15:36:51 -0700 Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 4AB127F8B; Tue, 7 Apr 2009 18:29:41 -0400 (CLT) Date: Tue, 7 Apr 2009 18:29:41 -0400 From: Alvaro Herrera To: Bruce Momjian Cc: Euler Taveira de Oliveira , PostgreSQL-documentation Subject: Re: log_min_duration_statement units Message-ID: <20090407222941.GV4525@alvh.no-ip.org> References: <49DACF22.2030304@timbira.com> <200904072223.n37MNG205211@momjian.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200904072223.n37MNG205211@momjian.us> User-Agent: Mutt/1.5.18 (2008-05-17) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0 (lists.commandprompt.com [207.173.203.159]); Tue, 07 Apr 2009 15:36:51 -0700 (PDT) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=1.693 tagged_above=0 required=5 tests=RCVD_IN_NJABL_PROXY=1.693 X-Spam-Level: * X-Archive-Number: 200904/21 X-Sequence-Number: 5109 Bruce Momjian wrote: > Euler Taveira de Oliveira wrote: > > Bruce Momjian escreveu: > > > Oops, here is the patch; Euler, would you look to see if you can find > > > anything else missing; you seem to be good at that. :-) > > > > > My English is not as good as yours but here is another try. Personally, I > > prefer the second one but... > > Great, I used your second version. I had already done some of the ones > you found, but you had many more. I also used your "0 disables" wording > consistently in the file. Thanks for the help. Committed. Huh ... I thought the units were removed from the descriptions when the whole unit thing got introduced in guc.c. This seems more a regression than anything else -- see guc.c rev 1.361. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support