From: Bruce Momjian <bruce@momjian.us>
Message-Id: <200904072232.n37MW9F06630@momjian.us>
Subject: Re: log_min_duration_statement units
In-Reply-To: <20090407222941.GV4525@alvh.no-ip.org>
To: Alvaro Herrera <alvherre@commandprompt.com>
Date: Tue, 7 Apr 2009 18:32:09 -0400 (EDT)
CC: Euler Taveira de Oliveira <euler@timbira.com>,
	PostgreSQL-documentation <pgsql-docs@postgresql.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Euler Taveira de Oliveira wrote:
> > > Bruce Momjian escreveu:
> > > > Oops, here is the patch;  Euler, would you look to see if you can find
> > > > anything else missing;  you seem to be good at that.  :-)
> > > > 
> > > My English is not as good as yours but here is another try. Personally, I 
> > > prefer the second one but...
> > 
> > Great, I used your second version.  I had already done some of the ones
> > you found, but you had many more.  I also used your "0 disables" wording
> > consistently in the file.  Thanks for the help.  Committed.
> 
> Huh ... I thought the units were removed from the descriptions when the
> whole unit thing got introduced in guc.c.  This seems more a regression
> than anything else -- see guc.c rev 1.361.

Which is why I originally did:

	#log_min_duration_statement = -1ms        # -1 is disabled, 0 logs all statements

but people complained so I went with adding it to the description.  The
units are only to document the default if no units are supplied.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +