Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id 90BB3632B76 for ; Tue, 7 Apr 2009 20:28:05 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 59150-03 for ; Tue, 7 Apr 2009 20:27:56 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from momjian.us (momjian.us [70.90.9.53]) by mail.postgresql.org (Postfix) with ESMTP id 5B1516327AF for ; Tue, 7 Apr 2009 20:28:03 -0300 (ADT) Received: (from bruce@localhost) by momjian.us (8.11.6/8.11.6) id n37NRu513852; Tue, 7 Apr 2009 19:27:56 -0400 (EDT) From: Bruce Momjian Message-Id: <200904072327.n37NRu513852@momjian.us> Subject: Re: log_min_duration_statement units In-Reply-To: <24208.1239144707@sss.pgh.pa.us> To: Tom Lane Date: Tue, 7 Apr 2009 19:27:56 -0400 (EDT) CC: Euler Taveira de Oliveira , PostgreSQL-documentation X-Mailer: ELM [version 2.4ME+ PL124 (25)] MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="ELM1239146876-26575-2_" Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.069 tagged_above=0 required=5 tests=AWL=0.069 X-Spam-Level: X-Archive-Number: 200904/26 X-Sequence-Number: 5114 --ELM1239146876-26575-2_ Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="US-ASCII" Tom Lane wrote: > Bruce Momjian writes: > > Tom Lane wrote: > >> You know, it suddenly strikes me that this is going in largely the wrong > >> direction. > > > Right, the problem particularly is with the -1/special values that don't > > have a real unit. > > I don't object to what you did to postgresql.conf.sample, but I think > you should revert the changes to the descriptions in guc.c. Agreed; attached patch applied. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + --ELM1239146876-26575-2_ Content-Transfer-Encoding: 7bit Content-Type: text/x-diff Content-Disposition: inline; filename="/rtmp/diff" Index: guc.c =================================================================== RCS file: /cvsroot/pgsql/src/backend/utils/misc/guc.c,v retrieving revision 1.499 retrieving revision 1.501 diff -c -c -r1.499 -r1.501 *** guc.c 2 Apr 2009 19:57:19 -0000 1.499 --- guc.c 7 Apr 2009 22:22:19 -0000 1.501 *************** *** 10,16 **** * Written by Peter Eisentraut . * * IDENTIFICATION ! * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.499 2009/04/02 19:57:19 momjian Exp $ * *-------------------------------------------------------------------- */ --- 10,16 ---- * Written by Peter Eisentraut . * * IDENTIFICATION ! * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.501 2009/04/07 22:22:19 momjian Exp $ * *-------------------------------------------------------------------- */ *************** *** 1316,1322 **** { /* This is PGC_SIGHUP so all backends have the same value. */ {"deadlock_timeout", PGC_SIGHUP, LOCK_MANAGEMENT, ! gettext_noop("Sets the time to wait on a lock before checking for deadlock."), NULL, GUC_UNIT_MS }, --- 1316,1322 ---- { /* This is PGC_SIGHUP so all backends have the same value. */ {"deadlock_timeout", PGC_SIGHUP, LOCK_MANAGEMENT, ! gettext_noop("Sets the time to wait on a lock before checking for deadlock, in milliseconds."), NULL, GUC_UNIT_MS }, *************** *** 1406,1412 **** { {"maintenance_work_mem", PGC_USERSET, RESOURCES_MEM, ! gettext_noop("Sets the maximum memory to be used for maintenance operations."), gettext_noop("This includes operations such as VACUUM and CREATE INDEX."), GUC_UNIT_KB }, --- 1406,1412 ---- { {"maintenance_work_mem", PGC_USERSET, RESOURCES_MEM, ! gettext_noop("Sets the maximum memory to be used for maintenance operations, in kilobytes."), gettext_noop("This includes operations such as VACUUM and CREATE INDEX."), GUC_UNIT_KB }, *************** *** 1530,1536 **** { {"statement_timeout", PGC_USERSET, CLIENT_CONN_STATEMENT, ! gettext_noop("Sets the maximum allowed duration of any statement."), gettext_noop("A value of 0 turns off the timeout."), GUC_UNIT_MS }, --- 1530,1536 ---- { {"statement_timeout", PGC_USERSET, CLIENT_CONN_STATEMENT, ! gettext_noop("Sets the maximum duration of any statement, in milliseconds."), gettext_noop("A value of 0 turns off the timeout."), GUC_UNIT_MS }, *************** *** 1569,1575 **** { {"authentication_timeout", PGC_SIGHUP, CONN_AUTH_SECURITY, ! gettext_noop("Sets the maximum allowed time to complete client authentication."), NULL, GUC_UNIT_S }, --- 1569,1575 ---- { {"authentication_timeout", PGC_SIGHUP, CONN_AUTH_SECURITY, ! gettext_noop("Sets the maximum allowed time to complete client authentication, in seconds."), NULL, GUC_UNIT_S }, *************** *** 1599,1605 **** { {"checkpoint_timeout", PGC_SIGHUP, WAL_CHECKPOINTS, ! gettext_noop("Sets the maximum time between automatic WAL checkpoints."), NULL, GUC_UNIT_S }, --- 1599,1605 ---- { {"checkpoint_timeout", PGC_SIGHUP, WAL_CHECKPOINTS, ! gettext_noop("Sets the maximum time between automatic WAL checkpoints, in seconds."), NULL, GUC_UNIT_S }, *************** *** 1632,1638 **** { {"wal_writer_delay", PGC_SIGHUP, WAL_SETTINGS, ! gettext_noop("WAL writer sleep time between WAL flushes."), NULL, GUC_UNIT_MS }, --- 1632,1638 ---- { {"wal_writer_delay", PGC_SIGHUP, WAL_SETTINGS, ! gettext_noop("WAL writer sleep time between WAL flushes, in milliseconds."), NULL, GUC_UNIT_MS }, *************** *** 1673,1680 **** { {"log_min_duration_statement", PGC_SUSET, LOGGING_WHEN, ! gettext_noop("Sets the minimum execution time above which " ! "statements will be logged."), gettext_noop("Zero prints all queries. -1 turns this feature off."), GUC_UNIT_MS }, --- 1673,1680 ---- { {"log_min_duration_statement", PGC_SUSET, LOGGING_WHEN, ! gettext_noop("Sets the minimum execution time (in milliseconds) above " ! "which statements will be logged."), gettext_noop("Zero prints all queries. -1 turns this feature off."), GUC_UNIT_MS }, *************** *** 1684,1690 **** { {"log_autovacuum_min_duration", PGC_SIGHUP, LOGGING_WHAT, ! gettext_noop("Sets the minimum execution time above which " "autovacuum actions will be logged."), gettext_noop("Zero prints all actions. -1 turns autovacuum logging off."), GUC_UNIT_MS --- 1684,1690 ---- { {"log_autovacuum_min_duration", PGC_SIGHUP, LOGGING_WHAT, ! gettext_noop("Sets the minimum execution in milliseconds above which " "autovacuum actions will be logged."), gettext_noop("Zero prints all actions. -1 turns autovacuum logging off."), GUC_UNIT_MS *************** *** 1695,1701 **** { {"bgwriter_delay", PGC_SIGHUP, RESOURCES, ! gettext_noop("Background writer sleep time between rounds."), NULL, GUC_UNIT_MS }, --- 1695,1701 ---- { {"bgwriter_delay", PGC_SIGHUP, RESOURCES, ! gettext_noop("Background writer sleep time between rounds, in milliseconds."), NULL, GUC_UNIT_MS }, *************** *** 1827,1833 **** { {"autovacuum_naptime", PGC_SIGHUP, AUTOVACUUM, ! gettext_noop("Time to sleep between autovacuum runs."), NULL, GUC_UNIT_S }, --- 1827,1833 ---- { {"autovacuum_naptime", PGC_SIGHUP, AUTOVACUUM, ! gettext_noop("Time to sleep between autovacuum runs, in seconds."), NULL, GUC_UNIT_S }, *************** *** 1871,1877 **** { {"tcp_keepalives_idle", PGC_USERSET, CLIENT_CONN_OTHER, ! gettext_noop("Time between issuing TCP keepalives."), gettext_noop("A value of 0 uses the system default."), GUC_UNIT_S }, --- 1871,1877 ---- { {"tcp_keepalives_idle", PGC_USERSET, CLIENT_CONN_OTHER, ! gettext_noop("Seconds between issuing TCP keepalives."), gettext_noop("A value of 0 uses the system default."), GUC_UNIT_S }, *************** *** 1881,1887 **** { {"tcp_keepalives_interval", PGC_USERSET, CLIENT_CONN_OTHER, ! gettext_noop("Time between TCP keepalive retransmits."), gettext_noop("A value of 0 uses the system default."), GUC_UNIT_S }, --- 1881,1887 ---- { {"tcp_keepalives_interval", PGC_USERSET, CLIENT_CONN_OTHER, ! gettext_noop("Seconds between TCP keepalive retransmits."), gettext_noop("A value of 0 uses the system default."), GUC_UNIT_S }, --ELM1239146876-26575-2_--