Received: from maia.hub.org (unknown [200.46.208.211])
	by mail.postgresql.org (Postfix) with ESMTP id 9D475632FC0
	for <pgsql-docs-postgresql.org@mail.postgresql.org>;
	Wed, 24 Feb 2010 12:29:11 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.208.211]) (amavisd-maia,
	port 10024) with ESMTP id 63905-05-4 for
	<pgsql-docs-postgresql.org@mail.postgresql.org>;
	Wed, 24 Feb 2010 16:29:00 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from momjian.us (momjian.us [70.90.9.53])
	by mail.postgresql.org (Postfix) with ESMTP id 9B099632FF8
	for <pgsql-docs@postgresql.org>; Wed, 24 Feb 2010 12:28:46 -0400 (AST)
Received: (from bruce@localhost) by momjian.us (8.11.6/8.11.6) id
 o1OGSi425961;
	Wed, 24 Feb 2010 11:28:44 -0500 (EST)
From: Bruce Momjian <bruce@momjian.us>
Message-Id: <201002241628.o1OGSi425961@momjian.us>
Subject: Re: Improve pg_restore docs
In-Reply-To: <4A4904BE.2070306@sfu.ca>
To: Mike Toews <mwtoews@sfu.ca>
Date: Wed, 24 Feb 2010 11:28:44 -0500 (EST)
CC: pgsql-docs@postgresql.org
X-Mailer: ELM [version 2.4ME+ PL124 (25)]
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="ELM1267028924-21988-0_"
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-2.375 tagged_above=-10 required=5 tests=AWL=0.224,
	BAYES_00=-2.599
X-Spam-Level: 
X-Archive-Number: 201002/27
X-Sequence-Number: 5343


--ELM1267028924-21988-0_
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

Mike Toews wrote:
> Hi,
> 
>  From a quick discussion on hackers 
> (http://archives.postgresql.org/pgsql-hackers/2009-06/msg01434.php), it 
> appears the documentation can improve for pg_restore.
> 
> I've prepared some quick diff output from 
> pgsql/doc/src/sgml/ref/pg_restore.sgml for some changes that I think 
> would help. Note that I'm not entirely sure about the default namespace 
> from default_path .. please verify this before accepting. Edit as necessary.
> 
> 291c291,292
> <         specific table.
> ---
>  >         specific table.  The default is taken from the
>  >         <envar>default_path</envar> variable.
> 379c380,382
> <         Restore definition and/or data of named table only.
> ---
>  >         Restore definition and/or data of named table only. This can be
>  >         combined with the <option>-n</option> option to restore a table
>  >         from a specific schema.

I have applied a modified version of your second change to our
documentation.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do
  + If your life is a hard drive, Christ can be your backup. +

--ELM1267028924-21988-0_
Content-Transfer-Encoding: 7bit
Content-Type: text/x-diff
Content-Disposition: inline; filename="/rtmp/diff"

Index: doc/src/sgml/ref/pg_restore.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/ref/pg_restore.sgml,v
retrieving revision 1.85
diff -c -c -r1.85 pg_restore.sgml
*** doc/src/sgml/ref/pg_restore.sgml	23 Feb 2010 00:21:19 -0000	1.85
--- doc/src/sgml/ref/pg_restore.sgml	24 Feb 2010 16:27:14 -0000
***************
*** 377,383 ****
        <term><option>--table=<replaceable class="parameter">table</replaceable></option></term>
        <listitem>
         <para>
!         Restore definition and/or data of named table only.
         </para>
        </listitem>
       </varlistentry>
--- 377,384 ----
        <term><option>--table=<replaceable class="parameter">table</replaceable></option></term>
        <listitem>
         <para>
!         Restore definition and/or data of named table only.  This can be
!         combined with the <option>-n</option> option to specify a schema.
         </para>
        </listitem>
       </varlistentry>

--ELM1267028924-21988-0_--