From: Bruce Momjian <bruce@momjian.us>
Message-Id: <201002251847.o1PIl3h23647@momjian.us>
Subject: Re: [PATCH] log_statement docs
In-Reply-To: <48bb92b1002250921k3a1ae0a0xab26038ccaae089d@mail.gmail.com>
To: gabrielle <gorthx@gmail.com>
Date: Thu, 25 Feb 2010 13:47:03 -0500 (EST)
CC: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-docs@postgresql.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

gabrielle wrote:
> On Wed, Feb 24, 2010 at 7:14 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > gabrielle <gorthx@gmail.com> writes:
> >> Patch amends description of log_statement to include definition of "all" option.
> >
> > Shouldn't it just say "all means all", if we think that needs to be
> > explained?
> 
> I think it should say something about the "all" option.  I read &
> re-read that section trying to figure out what the difference between
> "mod" and "all" was, and finally asked on the irc channel.  As it
> stands, it essentially says "there are three options to this command,
> but we're only going to tell you about two of them." :)

Well, if you take a look at utility.c:GetCommandLogLevel() you will see
that ALL includes a lot more commands than just SELECT.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do
  + If your life is a hard drive, Christ can be your backup. +