Received: from maia.hub.org (unknown [200.46.208.211])
	by mail.postgresql.org (Postfix) with ESMTP id 033BE633515
	for <pgsql-docs-postgresql.org@mail.postgresql.org>;
	Thu, 25 Feb 2010 15:20:55 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.208.211]) (amavisd-maia,
	port 10024) with ESMTP id 98190-04 for
	<pgsql-docs-postgresql.org@mail.postgresql.org>;
	Thu, 25 Feb 2010 19:20:41 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from momjian.us (momjian.us [70.90.9.53])
	by mail.postgresql.org (Postfix) with ESMTP id 11FAC63269C
	for <pgsql-docs@postgresql.org>; Thu, 25 Feb 2010 15:20:43 -0400 (AST)
Received: (from bruce@localhost) by momjian.us (8.11.6/8.11.6) id
 o1PJKfM01351;
	Thu, 25 Feb 2010 14:20:41 -0500 (EST)
From: Bruce Momjian <bruce@momjian.us>
Message-Id: <201002251920.o1PJKfM01351@momjian.us>
Subject: Re: [PATCH] log_statement docs
In-Reply-To: <7494.1267124877@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Date: Thu, 25 Feb 2010 14:20:41 -0500 (EST)
CC: gabrielle <gorthx@gmail.com>, pgsql-docs@postgresql.org
X-Mailer: ELM [version 2.4ME+ PL124 (25)]
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="ELM1267125641-21988-1_"
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-2.376 tagged_above=-10 required=5 tests=AWL=0.223,
	BAYES_00=-2.599
X-Spam-Level: 
X-Archive-Number: 201002/45
X-Sequence-Number: 5361


--ELM1267125641-21988-1_
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > gabrielle wrote:
> >> On Wed, Feb 24, 2010 at 7:14 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >>> Shouldn't it just say "all means all", if we think that needs to be
> >>> explained?
> >> 
> >> I think it should say something about the "all" option.  I read &
> >> re-read that section trying to figure out what the difference between
> >> "mod" and "all" was, and finally asked on the irc channel.  As it
> >> stands, it essentially says "there are three options to this command,
> >> but we're only going to tell you about two of them." :)
> 
> > Well, if you take a look at utility.c:GetCommandLogLevel() you will see
> > that ALL includes a lot more commands than just SELECT.
> 
> Yeah.  My objection was not to documenting ALL, it was to documenting it
> with exactly that sentence, which seems both needlessly complicated and
> subject to errors of omission.

I have applied the following patch with adds "off" and "all statements"
identifiers.  This is probaby the right level of detail for this.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do
  + If your life is a hard drive, Christ can be your backup. +

--ELM1267125641-21988-1_
Content-Transfer-Encoding: 7bit
Content-Type: text/x-diff
Content-Disposition: inline; filename="/rtmp/diff"

Index: doc/src/sgml/config.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/config.sgml,v
retrieving revision 1.253
diff -c -c -r1.253 config.sgml
*** doc/src/sgml/config.sgml	25 Feb 2010 13:26:15 -0000	1.253
--- doc/src/sgml/config.sgml	25 Feb 2010 19:19:14 -0000
***************
*** 3392,3399 ****
        <listitem>
         <para>
          Controls which SQL statements are logged. Valid values are
!         <literal>none</>, <literal>ddl</>, <literal>mod</>, and
!         <literal>all</>. <literal>ddl</> logs all data definition
          statements, such as <command>CREATE</>, <command>ALTER</>, and
          <command>DROP</> statements. <literal>mod</> logs all
          <literal>ddl</> statements, plus data-modifying statements
--- 3392,3399 ----
        <listitem>
         <para>
          Controls which SQL statements are logged. Valid values are
!         <literal>none</> (off), <literal>ddl</>, <literal>mod</>, and
!         <literal>all</> (all statements). <literal>ddl</> logs all data definition
          statements, such as <command>CREATE</>, <command>ALTER</>, and
          <command>DROP</> statements. <literal>mod</> logs all
          <literal>ddl</> statements, plus data-modifying statements

--ELM1267125641-21988-1_--