Received: from maia.hub.org (unknown [200.46.208.211])
	by mail.postgresql.org (Postfix) with ESMTP id 9C9E7634EE9
	for <pgsql-docs-postgresql.org@mail.postgresql.org>;
	Fri, 26 Feb 2010 23:47:39 -0400 (AST)
Received: from mail.postgresql.org ([200.46.204.86])
	by maia.hub.org (mx1.hub.org [200.46.208.211]) (amavisd-maia,
	port 10024) with ESMTP id 54700-02-6 for
	<pgsql-docs-postgresql.org@mail.postgresql.org>;
	Sat, 27 Feb 2010 03:47:19 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from momjian.us (momjian.us [70.90.9.53])
	by mail.postgresql.org (Postfix) with ESMTP id 24923636856
	for <pgsql-docs@postgresql.org>; Fri, 26 Feb 2010 23:41:44 -0400 (AST)
Received: (from bruce@localhost) by momjian.us (8.11.6/8.11.6) id
 o1R3faR28473;
	Fri, 26 Feb 2010 22:41:36 -0500 (EST)
From: Bruce Momjian <bruce@momjian.us>
Message-Id: <201002270341.o1R3faR28473@momjian.us>
Subject: Re: libpq-example.html needs to use <> includes
In-Reply-To: <4B85D45A.5050507@agliodbs.com>
To: Josh Berkus <josh@agliodbs.com>
Date: Fri, 26 Feb 2010 22:41:36 -0500 (EST)
CC: pgsql-docs@postgresql.org
X-Mailer: ELM [version 2.4ME+ PL124 (25)]
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="ELM1267242096-12797-5_"
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-2.379 tagged_above=-10 required=5 tests=AWL=0.220,
	BAYES_00=-2.599
X-Spam-Level: 
X-Archive-Number: 201002/48
X-Sequence-Number: 5364


--ELM1267242096-12797-5_
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

Josh Berkus wrote:
> All,
> 
> The libpq-example is using local includes for libpq-fe, instead of
> library includes:
> 
> #include "libpq-fe.h"
> 
> I can't think of a single good reason for this, is there one?

Agreed, fixed with the attached, applied patch.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do
  + If your life is a hard drive, Christ can be your backup. +

--ELM1267242096-12797-5_
Content-Transfer-Encoding: 7bit
Content-Type: text/x-diff
Content-Disposition: inline; filename="/rtmp/diff"

Index: doc/src/sgml/libpq.sgml
===================================================================
RCS file: /cvsroot/pgsql/doc/src/sgml/libpq.sgml,v
retrieving revision 1.302
diff -c -c -r1.302 libpq.sgml
*** doc/src/sgml/libpq.sgml	24 Feb 2010 15:54:31 -0000	1.302
--- doc/src/sgml/libpq.sgml	27 Feb 2010 03:40:36 -0000
***************
*** 7010,7016 ****
   */
  #include <stdio.h>
  #include <stdlib.h>
! #include "libpq-fe.h"
  
  static void
  exit_nicely(PGconn *conn)
--- 7010,7016 ----
   */
  #include <stdio.h>
  #include <stdlib.h>
! #include <libpq-fe.h>
  
  static void
  exit_nicely(PGconn *conn)
***************
*** 7158,7164 ****
  #include <string.h>
  #include <errno.h>
  #include <sys/time.h>
! #include "libpq-fe.h"
  
  static void
  exit_nicely(PGconn *conn)
--- 7158,7164 ----
  #include <string.h>
  #include <errno.h>
  #include <sys/time.h>
! #include <libpq-fe.h>
  
  static void
  exit_nicely(PGconn *conn)
***************
*** 7296,7302 ****
  #include <stdlib.h>
  #include <string.h>
  #include <sys/types.h>
! #include "libpq-fe.h"
  
  /* for ntohl/htonl */
  #include <netinet/in.h>
--- 7296,7302 ----
  #include <stdlib.h>
  #include <string.h>
  #include <sys/types.h>
! #include <libpq-fe.h>
  
  /* for ntohl/htonl */
  #include <netinet/in.h>

--ELM1267242096-12797-5_--