From: Bruce Momjian <bruce@momjian.us>
Message-Id: <201004010031.o310VW506970@momjian.us>
Subject: Re: confusing archive_command example
In-Reply-To: <1251.1270080183@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 31 Mar 2010 20:31:32 -0400 (EDT)
CC: Josh Kupershmidt <schmiddy@gmail.com>, pgsql-docs@postgresql.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > His complaint was that .../%f looks like ../%f;  is that a valid
> > concern?
> 
> Well, it does look like it, I'm just not seeing an easy fix that makes
> that better.  I think the original suggestion was to turn it into a
> concrete example by writing something like /mnt/archive/%f.
> 
> > I have reverted the change.  Also, should we be using test !
> > -e instead of -f?
> 
> No opinion.

Well -e tests for any type of file, while -f is only for regular files. 
In practice, there should only be regular files in the archive
directory.  But because we are always super-cautious, I changed it to
-e.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com