public inbox for [email protected]help / color / mirror / Atom feed
docs cleanup patch 9+ messages / 4 participants [nested] [flat]
* docs cleanup patch @ 2010-03-26 03:43 Josh Kupershmidt <[email protected]> 0 siblings, 1 reply; 9+ messages in thread From: Josh Kupershmidt @ 2010-03-26 03:43 UTC (permalink / raw) To: pgsql-docs Hi all, Here's a patch which mostly fixes broken URLs in code comments. Summary of doc. changes: * heapfuncs.c: fix awkward comment phrasing I also tried to fix as many broken URLs as I could find. * imath.h, imath.c: homepage for M.J. Fromberger moved * sha1.c, sha1.h: new location of FIPS pub 180-1 * sha2.c: changed URL of PDF describing SHA-256/384/512 to one of the only active links I could find. archive.org still has the old copy at http://web.archive.org/web/*/http://csrc.nist.gov/cryptval/shs/sha256-384-512.pdf * spell.h: I think this was just pointing to the manpage for hunspell. I changed to the project page for hunspell, though maybe it'd be better to point to some other copy of the man page somewhere, e.g. http://pwet.fr/man/linux/fichiers_speciaux/hunspell * dirmod.c: codeproject.com has shuffled pages Didn't change: * be-secure.c: the URL http://www.skip-vpn.org/spec/numbers.html is down, and I can't find an active copy anywhere else, so I didn't try to change this. archive.org still has it though ( http://web.archive.org/web/20011212141438/http://www.skip-vpn.org/spec/numbers.html ) Josh Attachments: [application/octet-stream] docs_cleanup.patch (6.1K, 2-docs_cleanup.patch) download | inline diff: diff --git a/contrib/pageinspect/heapfuncs.c b/contrib/pageinspect/heapfuncs.c index fe99feb..3f16188 100644 *** a/contrib/pageinspect/heapfuncs.c --- b/contrib/pageinspect/heapfuncs.c *************** *** 7,16 **** * might cause crashes, but at the same time we try to print out as much * information as possible, even if it's nonsense. That's because if a * page is corrupt, we don't know why and how exactly it is corrupt, so we ! * let the user to judge it. * * These functions are restricted to superusers for the fear of introducing ! * security holes if the input checking isn't as water-tight as it should. * You'd need to be superuser to obtain a raw page image anyway, so * there's hardly any use case for using these without superuser-rights * anyway. --- 7,16 ---- * might cause crashes, but at the same time we try to print out as much * information as possible, even if it's nonsense. That's because if a * page is corrupt, we don't know why and how exactly it is corrupt, so we ! * let the user judge it. * * These functions are restricted to superusers for the fear of introducing ! * security holes if the input checking isn't as water-tight as it should be. * You'd need to be superuser to obtain a raw page image anyway, so * there's hardly any use case for using these without superuser-rights * anyway. diff --git a/contrib/pgcrypto/imath.c b/contrib/pgcrypto/imath.c index 142a49b..4f0dad1 100644 *** a/contrib/pgcrypto/imath.c --- b/contrib/pgcrypto/imath.c *************** *** 2,8 **** /* Name: imath.c Purpose: Arbitrary precision integer arithmetic routines. ! Author: M. J. Fromberger <http://www.dartmouth.edu/~sting/> Info: Id: imath.c 21 2006-04-02 18:58:36Z sting Copyright (C) 2002 Michael J. Fromberger, All Rights Reserved. --- 2,8 ---- /* Name: imath.c Purpose: Arbitrary precision integer arithmetic routines. ! Author: M. J. Fromberger <http://spinning-yarns.org/michael/sw/> Info: Id: imath.c 21 2006-04-02 18:58:36Z sting Copyright (C) 2002 Michael J. Fromberger, All Rights Reserved. diff --git a/contrib/pgcrypto/imath.h b/contrib/pgcrypto/imath.h index b65a8a9..e3d2f12 100644 *** a/contrib/pgcrypto/imath.h --- b/contrib/pgcrypto/imath.h *************** *** 1,7 **** /* Name: imath.h Purpose: Arbitrary precision integer arithmetic routines. ! Author: M. J. Fromberger <http://www.dartmouth.edu/~sting/> Info: Id: imath.h 21 2006-04-02 18:58:36Z sting Copyright (C) 2002 Michael J. Fromberger, All Rights Reserved. --- 1,7 ---- /* Name: imath.h Purpose: Arbitrary precision integer arithmetic routines. ! Author: M. J. Fromberger <http://spinning-yarns.org/michael/sw/> Info: Id: imath.h 21 2006-04-02 18:58:36Z sting Copyright (C) 2002 Michael J. Fromberger, All Rights Reserved. diff --git a/contrib/pgcrypto/sha1.c b/contrib/pgcrypto/sha1.c index a33e463..23ba3f7 100644 *** a/contrib/pgcrypto/sha1.c --- b/contrib/pgcrypto/sha1.c *************** *** 32,38 **** */ /* * FIPS pub 180-1: Secure Hash Algorithm (SHA-1) ! * based on: http://csrc.nist.gov/fips/fip180-1.txt * implemented by Jun-ichiro itojun Itoh <[email protected]> */ --- 32,38 ---- */ /* * FIPS pub 180-1: Secure Hash Algorithm (SHA-1) ! * based on: http://www.itl.nist.gov/fipspubs/fip180-1.htm * implemented by Jun-ichiro itojun Itoh <[email protected]> */ diff --git a/contrib/pgcrypto/sha1.h b/contrib/pgcrypto/sha1.h index 1a1d664..5144670 100644 *** a/contrib/pgcrypto/sha1.h --- b/contrib/pgcrypto/sha1.h *************** *** 31,37 **** */ /* * FIPS pub 180-1: Secure Hash Algorithm (SHA-1) ! * based on: http://csrc.nist.gov/fips/fip180-1.txt * implemented by Jun-ichiro itojun Itoh <[email protected]> */ --- 31,37 ---- */ /* * FIPS pub 180-1: Secure Hash Algorithm (SHA-1) ! * based on: http://www.itl.nist.gov/fipspubs/fip180-1.htm * implemented by Jun-ichiro itojun Itoh <[email protected]> */ diff --git a/contrib/pgcrypto/sha2.c b/contrib/pgcrypto/sha2.c index c936ab8..7ac1dac 100644 *** a/contrib/pgcrypto/sha2.c --- b/contrib/pgcrypto/sha2.c *************** *** 98,105 **** * * NOTE: The naming of R and S appears backwards here (R is a SHIFT and * S is a ROTATION) because the SHA-256/384/512 description document ! * (see http://csrc.nist.gov/cryptval/shs/sha256-384-512.pdf) uses this ! * same "backwards" definition. */ /* Shift-right (used in SHA-256, SHA-384, and SHA-512): */ #define R(b,x) ((x) >> (b)) --- 98,105 ---- * * NOTE: The naming of R and S appears backwards here (R is a SHIFT and * S is a ROTATION) because the SHA-256/384/512 description document ! * (see http://www.iwar.org.uk/comsec/resources/cipher/sha256-384-512.pdf) ! * uses this same "backwards" definition. */ /* Shift-right (used in SHA-256, SHA-384, and SHA-512): */ #define R(b,x) ((x) >> (b)) diff --git a/src/include/tsearch/dicts/spell.h b/src/include/tsearch/dicts/spell.h index 6a021d5..ccb4fa4 100644 *** a/src/include/tsearch/dicts/spell.h --- b/src/include/tsearch/dicts/spell.h *************** typedef struct *** 37,43 **** /* * Names of FF_ are correlated with Hunspell options in affix file ! * http://sourceforge.net/docman/display_doc.php?docid=29374&group_id=143754 */ #define FF_COMPOUNDONLY 0x01 #define FF_COMPOUNDBEGIN 0x02 --- 37,43 ---- /* * Names of FF_ are correlated with Hunspell options in affix file ! * http://hunspell.sourceforge.net/ */ #define FF_COMPOUNDONLY 0x01 #define FF_COMPOUNDBEGIN 0x02 diff --git a/src/port/dirmod.c b/src/port/dirmod.c index 8543d4c..1156400 100644 *** a/src/port/dirmod.c --- b/src/port/dirmod.c *************** typedef struct *** 220,226 **** /* * pgsymlink - uses Win32 junction points * ! * For reference: http://www.codeproject.com/w2k/junctionpoints.asp */ int pgsymlink(const char *oldpath, const char *newpath) --- 220,226 ---- /* * pgsymlink - uses Win32 junction points * ! * For reference: http://www.codeproject.com/KB/winsdk/junctionpoints.aspx */ int pgsymlink(const char *oldpath, const char *newpath) ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: docs cleanup patch @ 2010-04-02 15:29 Magnus Hagander <[email protected]> parent: Josh Kupershmidt <[email protected]> 0 siblings, 1 reply; 9+ messages in thread From: Magnus Hagander @ 2010-04-02 15:29 UTC (permalink / raw) To: Josh Kupershmidt <[email protected]>; +Cc: pgsql-docs On Fri, Mar 26, 2010 at 04:43, Josh Kupershmidt <[email protected]> wrote: > Hi all, > Here's a patch which mostly fixes broken URLs in code comments. > > Summary of doc. changes: > * heapfuncs.c: fix awkward comment phrasing > > I also tried to fix as many broken URLs as I could find. > * imath.h, imath.c: homepage for M.J. Fromberger moved > * sha1.c, sha1.h: new location of FIPS pub 180-1 > * sha2.c: changed URL of PDF describing SHA-256/384/512 to one of the > only active links I could find. archive.org still has the old copy at > http://web.archive.org/web/*/http://csrc.nist.gov/cryptval/shs/sha256-384-512.pdf > * spell.h: I think this was just pointing to the manpage for > hunspell. I changed to the project page for hunspell, though maybe > it'd be better to point to some other copy of the man page somewhere, > e.g. http://pwet.fr/man/linux/fichiers_speciaux/hunspell > * dirmod.c: codeproject.com has shuffled pages Thanks, applied! > Didn't change: > * be-secure.c: the URL http://www.skip-vpn.org/spec/numbers.html is > down, and I can't find an active copy anywhere else, so I didn't try > to change this. archive.org still has it though ( > http://web.archive.org/web/20011212141438/http://www.skip-vpn.org/spec/numbers.html > ) The page in archive.org also refers to skip.org, which has expired and been eaten. Perhaps we should just remove that comment completely? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: docs cleanup patch @ 2010-04-13 22:15 Alvaro Herrera <[email protected]> parent: Magnus Hagander <[email protected]> 0 siblings, 1 reply; 9+ messages in thread From: Alvaro Herrera @ 2010-04-13 22:15 UTC (permalink / raw) To: Magnus Hagander <[email protected]>; +Cc: Josh Kupershmidt <[email protected]>; pgsql-docs Magnus Hagander escribió: > On Fri, Mar 26, 2010 at 04:43, Josh Kupershmidt <[email protected]> wrote: > > Didn't change: > > * be-secure.c: the URL http://www.skip-vpn.org/spec/numbers.html is > > down, and I can't find an active copy anywhere else, so I didn't try > > to change this. archive.org still has it though ( > > http://web.archive.org/web/20011212141438/http://www.skip-vpn.org/spec/numbers.html > > ) > > The page in archive.org also refers to skip.org, which has expired and > been eaten. Perhaps we should just remove that comment completely? Eh? The above link works for me (and contains suggested DH parameters, though not in the format expected by be-secure.c). -- Alvaro Herrera http://www.CommandPrompt.com/ The PostgreSQL Company - Command Prompt, Inc. ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: docs cleanup patch @ 2010-04-14 06:48 Magnus Hagander <[email protected]> parent: Alvaro Herrera <[email protected]> 0 siblings, 2 replies; 9+ messages in thread From: Magnus Hagander @ 2010-04-14 06:48 UTC (permalink / raw) To: Alvaro Herrera <[email protected]>; +Cc: Josh Kupershmidt <[email protected]>; pgsql-docs On Wed, Apr 14, 2010 at 12:15 AM, Alvaro Herrera <[email protected]> wrote: > Magnus Hagander escribió: >> On Fri, Mar 26, 2010 at 04:43, Josh Kupershmidt <[email protected]> wrote: > >> > Didn't change: >> > * be-secure.c: the URL http://www.skip-vpn.org/spec/numbers.html is >> > down, and I can't find an active copy anywhere else, so I didn't try >> > to change this. archive.org still has it though ( >> > http://web.archive.org/web/20011212141438/http://www.skip-vpn.org/spec/numbers.html >> > ) >> >> The page in archive.org also refers to skip.org, which has expired and >> been eaten. Perhaps we should just remove that comment completely? > > Eh? The above link works for me (and contains suggested DH parameters, > though not in the format expected by be-secure.c). Interesting - must be a routing issue or something then, because I still can't get to it. I've tried from machines in several different countries, though... Does the content of what you get on the site actually match what you get on the site itself? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: docs cleanup patch @ 2010-04-15 02:47 Bruce Momjian <[email protected]> parent: Magnus Hagander <[email protected]> 1 sibling, 0 replies; 9+ messages in thread From: Bruce Momjian @ 2010-04-15 02:47 UTC (permalink / raw) To: Magnus Hagander <[email protected]>; +Cc: Alvaro Herrera <[email protected]>; Josh Kupershmidt <[email protected]>; pgsql-docs Magnus Hagander wrote: > On Wed, Apr 14, 2010 at 12:15 AM, Alvaro Herrera > <[email protected]> wrote: > > Magnus Hagander escribi?: > >> On Fri, Mar 26, 2010 at 04:43, Josh Kupershmidt <[email protected]> wrote: > > > >> > Didn't change: > >> > ?* be-secure.c: the URL http://www.skip-vpn.org/spec/numbers.html is > >> > down, and I can't find an active copy anywhere else, so I didn't try > >> > to change this. archive.org still has it though ( > >> > http://web.archive.org/web/20011212141438/http://www.skip-vpn.org/spec/numbers.html > >> > ) > >> > >> The page in archive.org also refers to skip.org, which has expired and > >> been eaten. Perhaps we should just remove that comment completely? > > > > Eh? ?The above link works for me (and contains suggested DH parameters, > > though not in the format expected by be-secure.c). > > Interesting - must be a routing issue or something then, because I > still can't get to it. I've tried from machines in several different > countries, though... Does the content of what you get on the site > actually match what you get on the site itself? I cannot access it. -- Bruce Momjian <[email protected]> http://momjian.us EnterpriseDB http://enterprisedb.com ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: docs cleanup patch @ 2010-04-15 14:48 Alvaro Herrera <[email protected]> parent: Magnus Hagander <[email protected]> 1 sibling, 1 reply; 9+ messages in thread From: Alvaro Herrera @ 2010-04-15 14:48 UTC (permalink / raw) To: Magnus Hagander <[email protected]>; +Cc: Josh Kupershmidt <[email protected]>; pgsql-docs Magnus Hagander escribió: > On Wed, Apr 14, 2010 at 12:15 AM, Alvaro Herrera > <[email protected]> wrote: > > Magnus Hagander escribió: > >> On Fri, Mar 26, 2010 at 04:43, Josh Kupershmidt <[email protected]> wrote: > > > >> > Didn't change: > >> > * be-secure.c: the URL http://www.skip-vpn.org/spec/numbers.html is > >> > down, and I can't find an active copy anywhere else, so I didn't try > >> > to change this. archive.org still has it though ( > >> > http://web.archive.org/web/20011212141438/http://www.skip-vpn.org/spec/numbers.html > >> > ) > >> > >> The page in archive.org also refers to skip.org, which has expired and > >> been eaten. Perhaps we should just remove that comment completely? > > > > Eh? The above link works for me (and contains suggested DH parameters, > > though not in the format expected by be-secure.c). > > Interesting - must be a routing issue or something then, because I > still can't get to it. I've tried from machines in several different > countries, though... Maybe I was unclear. The archive.org URL works for me, the skip-vpn.org one doesn't (neither does skip.org). I must note that I tried the archive.org URL last night again upon seeing your email and was very surprised because it told me that that URL wasn't archived -- in fact none of skip-vpn.org was archived. Today it works again. > Does the content of what you get on the site actually match what you > get on the site itself? When you say "the site", which site are you referring to? -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: docs cleanup patch @ 2010-04-15 15:13 Magnus Hagander <[email protected]> parent: Alvaro Herrera <[email protected]> 0 siblings, 1 reply; 9+ messages in thread From: Magnus Hagander @ 2010-04-15 15:13 UTC (permalink / raw) To: Alvaro Herrera <[email protected]>; +Cc: Josh Kupershmidt <[email protected]>; pgsql-docs On Thu, Apr 15, 2010 at 4:48 PM, Alvaro Herrera <[email protected]> wrote: > Magnus Hagander escribió: >> On Wed, Apr 14, 2010 at 12:15 AM, Alvaro Herrera >> <[email protected]> wrote: >> > Magnus Hagander escribió: >> >> On Fri, Mar 26, 2010 at 04:43, Josh Kupershmidt <[email protected]> wrote: >> > >> >> > Didn't change: >> >> > * be-secure.c: the URL http://www.skip-vpn.org/spec/numbers.html is >> >> > down, and I can't find an active copy anywhere else, so I didn't try >> >> > to change this. archive.org still has it though ( >> >> > http://web.archive.org/web/20011212141438/http://www.skip-vpn.org/spec/numbers.html >> >> > ) >> >> >> >> The page in archive.org also refers to skip.org, which has expired and >> >> been eaten. Perhaps we should just remove that comment completely? >> > >> > Eh? The above link works for me (and contains suggested DH parameters, >> > though not in the format expected by be-secure.c). >> >> Interesting - must be a routing issue or something then, because I >> still can't get to it. I've tried from machines in several different >> countries, though... > > Maybe I was unclear. The archive.org URL works for me, the skip-vpn.org > one doesn't (neither does skip.org). Ok. Then yes, I read you wrong. I'm unsure if linking to archive.org is a good thing. I guess it's not likely to go away, but my original comment remains - perhaps we should just remove it and let people google for the info if they need it. > I must note that I tried the archive.org URL last night again upon > seeing your email and was very surprised because it told me that that > URL wasn't archived -- in fact none of skip-vpn.org was archived. Today > it works again. Strange. >> Does the content of what you get on the site actually match what you >> get on the site itself? > > When you say "the site", which site are you referring to? skip-vpn.org. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: docs cleanup patch @ 2010-04-15 15:43 Alvaro Herrera <[email protected]> parent: Magnus Hagander <[email protected]> 0 siblings, 1 reply; 9+ messages in thread From: Alvaro Herrera @ 2010-04-15 15:43 UTC (permalink / raw) To: Magnus Hagander <[email protected]>; +Cc: Josh Kupershmidt <[email protected]>; pgsql-docs Magnus Hagander escribió: > I'm unsure if linking to archive.org is a good thing. I guess it's not > likely to go away, but my original comment remains - perhaps we should > just remove it and let people google for the info if they need it. I guess the question is: how valuable is it to change the hardcoded fallback DH parameters? Surely if someone wants to use different DH params, they can set them in the documented files. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support ^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: docs cleanup patch @ 2010-04-16 10:21 Magnus Hagander <[email protected]> parent: Alvaro Herrera <[email protected]> 0 siblings, 0 replies; 9+ messages in thread From: Magnus Hagander @ 2010-04-16 10:21 UTC (permalink / raw) To: Alvaro Herrera <[email protected]>; +Cc: Josh Kupershmidt <[email protected]>; pgsql-docs On Thu, Apr 15, 2010 at 5:43 PM, Alvaro Herrera <[email protected]> wrote: > Magnus Hagander escribió: > >> I'm unsure if linking to archive.org is a good thing. I guess it's not >> likely to go away, but my original comment remains - perhaps we should >> just remove it and let people google for the info if they need it. > > I guess the question is: how valuable is it to change the hardcoded > fallback DH parameters? Surely if someone wants to use different DH > params, they can set them in the documented files. I've never heard anybody ask for that capability. I think that's more "developer notes" that ended up in comments... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ ^ permalink raw reply [nested|flat] 9+ messages in thread
end of thread, other threads:[~2010-04-16 10:21 UTC | newest] Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2010-03-26 03:43 docs cleanup patch Josh Kupershmidt <[email protected]> 2010-04-02 15:29 ` Magnus Hagander <[email protected]> 2010-04-13 22:15 ` Alvaro Herrera <[email protected]> 2010-04-14 06:48 ` Magnus Hagander <[email protected]> 2010-04-15 02:47 ` Bruce Momjian <[email protected]> 2010-04-15 14:48 ` Alvaro Herrera <[email protected]> 2010-04-15 15:13 ` Magnus Hagander <[email protected]> 2010-04-15 15:43 ` Alvaro Herrera <[email protected]> 2010-04-16 10:21 ` Magnus Hagander <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox