From: Bruce Momjian <bruce@momjian.us>
Message-Id: <201007022204.o62M4Tj29920@momjian.us>
Subject: Re: Documentation and explanatory diagrams
In-Reply-To: <alpine.BSF.2.00.1007021856560.45189@hub.org>
To: "Marc G. Fournier" <scrappy@hub.org>
Date: Fri, 2 Jul 2010 18:04:29 -0400 (EDT)
CC: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Alvaro Herrera <alvherre@commandprompt.com>,
	Peter Eisentraut <peter_e@gmx.net>,
	Rafael Martinez <r.m.guerrero@usit.uio.no>,
	pgsql-docs <pgsql-docs@postgresql.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

Marc G. Fournier wrote:
> On Fri, 2 Jul 2010, Bruce Momjian wrote:
> 
> > Marc G. Fournier wrote:
> >> On Fri, 2 Jul 2010, Robert Haas wrote:
> >>
> >>> On Fri, Jul 2, 2010 at 5:28 PM, Bruce Momjian <bruce@momjian.us> wrote:
> >>>> OK, everyone seems to like requiring dia.
> >>>
> >>> I don't like it a bit.  It's hard enough for people to build the docs as
> >>> it is.
> >>
> >> Why should anyone build the docs?  Its part of the tarball process, so the
> >> only ppl that should be doing it are those coming from CVS, no ... ?
> >
> > People often built them to verify the SGML markup and to view the
> > content/markup before submitting a doc patch.
> 
> Good point ... so, part of the Makefile should be modified for a flag to 
> disable dia build?  "make NO_DIA=yes" ?  Or, maybe have it default to NO 
> and for the tarball build, I'd modify the script for building it?

I am afraid if we don't enable dia by default then we will end up with
production documentation without images.  I think we have to default dia
to on, and give a reasonable error when it doesn't exist, and mention
how to turn it off.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + None of us is going to be here forever. +