DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:to:subject:date:user-agent:mime-version:content-type
	:message-id;
	b=jS6wFAKTZEWZpFkpot0Z/QPF2sNnSI8HgrsmckRKGn3bqMNAT22cJg1Gjz7JJIQNc8
	GtBa1CVDYPF0+OlXOTI8/XXg5crNBhH37xp0n1xtD+VMw5GMcAu6k4A+p7bBXx8ToZiJ
	s2H+FPZbdsX/hmzmBBbqtHyhD6S4/Ul9NBqQA=
From: Marc Cousin <cousinmarc@gmail.com>
To: pgsql-docs@postgresql.org
Subject: error in oracle to plpgsql documentation ?
Date: Wed, 21 Jul 2010 14:41:17 +0200
User-Agent: KMail/1.13.5 (Linux/2.6.34-ARCH; KDE/4.4.92; x86_64; ; )
MIME-Version: 1.0
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_truRMltLGxyKFxL"
Message-Id: <201007211441.17678.cousinmarc@gmail.com>

--Boundary-00=_truRMltLGxyKFxL
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit

Hi,

A user had a syntax problem with a cursor declaration. After a bit of digging, 
the code he used came directly from the documentation :

DECLARE
    CURSOR referrer_keys IS
        SELECT * FROM cs_referrer_keys
        ORDER BY try_order;
    func_body text;
    func_cmd text;

I guess it should be

DECLARE
    referrer_keys CURSOR IS
        SELECT * FROM cs_referrer_keys
        ORDER BY try_order;
    func_body text;
    func_cmd text;

(syntax is inverted in Oracle, so I guess it is a typo ?)

If I'm right, a patch is attached (the code works with the correction)


--Boundary-00=_truRMltLGxyKFxL
Content-Type: text/x-patch; charset="us-ascii"; name="patch_plpgsql_example"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="patch_plpgsql_example"

diff -r -c postgresql-orig/doc/src/sgml/plpgsql.sgml postgresql/doc/src/sgml/plpgsql.sgml
*** postgresql-orig/doc/src/sgml/plpgsql.sgml	2010-07-21 14:36:14.208439968 +0200
--- postgresql/doc/src/sgml/plpgsql.sgml	2010-07-21 14:37:13.921785739 +0200
***************
*** 4279,4285 ****
  <programlisting>
  CREATE OR REPLACE FUNCTION cs_update_referrer_type_proc() RETURNS void AS $func$
  DECLARE
!     CURSOR referrer_keys IS
          SELECT * FROM cs_referrer_keys
          ORDER BY try_order;
      func_body text;
--- 4279,4285 ----
  <programlisting>
  CREATE OR REPLACE FUNCTION cs_update_referrer_type_proc() RETURNS void AS $func$
  DECLARE
!     referrer_keys CURSOR IS
          SELECT * FROM cs_referrer_keys
          ORDER BY try_order;
      func_body text;

--Boundary-00=_truRMltLGxyKFxL--