Received: from maia.hub.org (maia-5.hub.org [200.46.204.29]) by mail.postgresql.org (Postfix) with ESMTP id D126A1336971 for ; Mon, 7 Feb 2011 11:55:07 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024) with ESMTP id 89023-09 for ; Mon, 7 Feb 2011 15:55:02 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from momjian.us (momjian.us [70.90.9.53]) by mail.postgresql.org (Postfix) with ESMTP id 3C6931337B54 for ; Mon, 7 Feb 2011 11:55:00 -0400 (AST) Received: (from bruce@localhost) by momjian.us (8.11.6/8.11.6) id p17Fswe20719; Mon, 7 Feb 2011 10:54:58 -0500 (EST) From: Bruce Momjian Message-Id: <201102071554.p17Fswe20719@momjian.us> Subject: Re: [COMMITTERS] pgsql: remove tags. In-Reply-To: To: Robert Haas Date: Mon, 7 Feb 2011 10:54:58 -0500 (EST) CC: Tom Lane , PostgreSQL-documentation X-Mailer: ELM [version 2.4ME+ PL124 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="US-ASCII" X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.91 tagged_above=-5 required=5 tests=BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01 X-Spam-Level: X-Archive-Number: 201102/32 X-Sequence-Number: 6380 Robert Haas wrote: > On Mon, Feb 7, 2011 at 9:54 AM, Bruce Momjian wrote: > > Robert Haas wrote: > >> On Sun, Feb 6, 2011 at 11:12 PM, Tom Lane wrote: > >> > Bruce Momjian writes: > >> >> Bruce Momjian wrote: > >> >>> remove tags. > >> > > >> >> Sorry, vague commit message (I forgot squash). > >> > > >> >> Can I will use git ammend to improve this message? > >> > >> Absolutely not. > >> > >> > How about git revert, instead? ?It's not apparent to me that these > >> > changes were improvements. > >> > >> I'll buy that one. > > > > [ ?CC to docs, committers removed. ] > > > > Well, if we want to revert, then we have to add to all the > > numbers used in our docs --- there was no logic in what we previously > > had. ?Do we want that? > > > > Here is an example line I did not change: > > > > ? an otherwise idle connection. ?A value of 0 uses the system default. > > > > Do we want that 0 to appear in a fixed-width font via ? > > It is easy to do but we should decide. > > [ removing -hackers from CC also, no need to cross-post ] > > Hmm. I'm starting to lean toward leaving this as you have it. > > Which way did we more commonly do it before you applied this patch? It was mostly like the line I have above, meaning it was not in fixed-width font, 95% I would say. I modified 19 to be like the rest. I left where the context made sense. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +