Received: from maia.hub.org (maia-5.hub.org [200.46.204.29]) by mail.postgresql.org (Postfix) with ESMTP id AC4C51337B83 for ; Mon, 7 Feb 2011 12:00:03 -0400 (AST) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.29]) (amavisd-maia, port 10024) with ESMTP id 92176-05 for ; Mon, 7 Feb 2011 15:59:56 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from momjian.us (momjian.us [70.90.9.53]) by mail.postgresql.org (Postfix) with ESMTP id 383B51337B54 for ; Mon, 7 Feb 2011 11:59:56 -0400 (AST) Received: (from bruce@localhost) by momjian.us (8.11.6/8.11.6) id p17Fxrb07886; Mon, 7 Feb 2011 10:59:53 -0500 (EST) From: Bruce Momjian Message-Id: <201102071559.p17Fxrb07886@momjian.us> Subject: Re: [COMMITTERS] pgsql: remove tags. In-Reply-To: <15595.1297091285@sss.pgh.pa.us> To: Tom Lane Date: Mon, 7 Feb 2011 10:59:53 -0500 (EST) CC: Robert Haas , PostgreSQL-documentation X-Mailer: ELM [version 2.4ME+ PL124 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="US-ASCII" X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-1.91 tagged_above=-5 required=5 tests=BAYES_00=-1.9, T_RP_MATCHES_RCVD=-0.01 X-Spam-Level: X-Archive-Number: 201102/34 X-Sequence-Number: 6382 Tom Lane wrote: > Robert Haas writes: > > Which way did we more commonly do it before you applied this patch? > > We don't have a standard for this, and an undocumented patch applied > without any discussion doesn't create one. It's hopeless to imagine > that you'll ever achieve any uniformity that way. It won't last long > if you do, since you're outnumbered by committers who won't be following > whatever you think the convention is. Well, the problem is that we then have paragraphs where a number is fixed width, and in the next paragraph it isn't; this is particuarly true in the config.sgml file where we show defaults. Seems worth trying to make that consistent. I am happy to do whatever we agree on --- I don't have an opinion. > I'm not even sure why you're trying --- I don't think it even makes > sense to try to have a standard about this. I can easily imagine that > integer constants might read better with in some contexts > and better without in others. Yes, I reviewed all the places and left where it made sense. -- Bruce Momjian http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +